-
Notifications
You must be signed in to change notification settings - Fork 75
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Do not execute tests using EventHostManualTrigger if not supported #546
Do not execute tests using EventHostManualTrigger if not supported #546
Conversation
Why is it only conditional enabled since CUDA 9. What is the reason for it? |
I do not know. I have not yet found any reasoning. |
When you are looking for other usages of |
There is still the error. I try to investigate this, why the test is executed.
|
it is only an issue on CUDA 8. CUDA 9 does not run the test, as stream memory operations are not supported ( |
Maybe they are not supported by default on CUDA 8? Maybe the flag was simply missing and it was expected to work everywhere but it did not so they introduced the new flag? |
I agree with you. It is not really supported in CUDA 8, so that test can be disabled in this case!?
(see PR #548, which fixes error reporting for driver API errors) |
@psychocoderHPC As far as I remember, this test once worked on your system using CUDA 8. Can you confirm or reevaluate this? |
@psychocoderHPC Could you please retest this on your CUDA 8 system? |
2ea6309
to
c0af872
Compare
@tdd11235813 Now the tests should not fail anymore on your system and #537 should be finished. Please approve if it is ok for you. |
c0af872
to
1945774
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
works for me, thanks a bunch for your work!
Adds a trait and a test method
isEventHostManualTriggerSupported
to not use theEventHostManualTrigger
when it is not supported. It was always supported with CUDA 8.0 but is only conditionally enabled in CUDA 9.This fixes the failing tests due to this disabled feature in #537 by checking the trait before executing the test.