Build all tests and examples from the main CMakeLists.txt and use ctest for test execution #562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BenjaminW3
commented
Jul 5, 2018
| cd "example/bufferCopy" && ./bufferCopy && cd ../.. | ||
| cd "example/helloWorld" && ./helloWorld && cd ../.. | ||
| cd "example/helloWorldLambda" && ./helloWorldLambda && cd ../.. | ||
| cd "example/vectorAdd" && ./vectorAdd && cd ../.. |
There was a problem hiding this comment.
I will add the examples to the tests in a separate PR.
BenjaminW3
force-pushed
the
topic-build-all
branch
4 times, most recently
from
ffa3172 to
d6f5def
Compare
psychocoderHPC
previously requested changes
Jul 6, 2018
| @@ -496,7 +496,7 @@ namespace alpaka | |||
| exec::cuda::detail::cudaKernel<TDim, TIdx, TKernelFnObj, TArgs...><<< | |||
| gridDim, | |||
| blockDim, | |||
| blockSharedMemDynSizeBytes, | |||
There was a problem hiding this comment.
Is this a bugfix? If so we should move it to a separate PR because this change not fits to the description.
There was a problem hiding this comment.
This fixes a warning that only occurs when ALPAKA_DEBUG==2 and was an error with Werror. I could create a new PR with the fix if you want.
There was a problem hiding this comment.
That would be nice because this is much easier to back-port.
There was a problem hiding this comment.
The fix has been merged separately
BenjaminW3
force-pushed
the
topic-build-all
branch
from
d6f5def to
b42ff81
Compare
…st for test execution
BenjaminW3
force-pushed
the
topic-build-all
branch
from
b42ff81 to
2d99d7a
Compare
|
Anything missing for this to be approved? |
BenjaminW3
dismissed
psychocoderHPC’s stale review
Review comments have been incorporated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes sure that #537 does not break again and that I can start with #543.