Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix sync manager being spawned inited in a separate thread #161

Closed
2 tasks
delbonis opened this issue Jul 17, 2024 · 0 comments · Fixed by #163
Closed
2 tasks

Fix sync manager being spawned inited in a separate thread #161

delbonis opened this issue Jul 17, 2024 · 0 comments · Fixed by #163
Assignees
Labels
bug Something isn't working refactor Reworking code to improve structure or performance

Comments

@delbonis
Copy link
Contributor

delbonis commented Jul 17, 2024

To fix a deadlock in a branch that should be merged by the time anyone reads this, some of the init work for the sync manager was moved into a short-lived thread that gets spawned when we start the sync manager tasks. This is the result of some initialization dependency issues around doing genesis and waiting for blocks from L1. This is really screwy and it didn't make sense at the time to do the refactorings in that branch, so I decided to just approve it that way, but it's really not how we should be doing it. Really we want to move some of those genesis duties into the CSM worker and add some extra signalling to do it elegantly and in response to the horizon threshold happening.

Relates to:

@delbonis delbonis added bug Something isn't working refactor Reworking code to improve structure or performance labels Jul 17, 2024
@delbonis delbonis self-assigned this Jul 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working refactor Reworking code to improve structure or performance
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant