Refactoring CSM startup #163
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 task
delbonis
force-pushed
the
feature/timely-l2-genesis
branch
2 times, most recently
from
7efb4b5 to
5594b49
Compare
|
Okay this is rebased onto master, should be reviewed. There's more I'd like to do to clean up stuff around this but we should ship this for now. |
…CM startup a bit more
…nels into `SyncManager`
delbonis
force-pushed
the
feature/timely-l2-genesis
branch
from
4e03a47 to
cfff4e5
Compare
delbonis
force-pushed
the
feature/timely-l2-genesis
branch
from
22a1d83 to
0a66c57
Compare
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## master #163 +/- ##
==========================================
- Coverage 52.65% 49.85% -2.81%
==========================================
Files 79 80 +1
Lines 6567 6880 +313
==========================================
- Hits 3458 3430 -28
- Misses 3109 3450 +341
|
|
Ignoring coverage report for now. |
|
Merging because a bunch of stuff is blocked on this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We likely will want to have deposits into the rollup preceeding genesis, so we can have activity in the rollup at genesis. So we now differentiate a "horizon" L1 block and a "L2 genesis" L1 block, and process stuff between these two blocks and after the L2 genesis L1 block is fairly buried we now initiate genesis, which is computed by the worker task I think, which kicks off the FCM to start running. The genesis block is computed strictly from the L1 data. This design and the requirements for it (and its downstream implications) wasn't immediately obvious until ~2 weeks ago. Another motivation was to clean up the startup process, which was previously really hacky because of changes made after another feature that was added and I forgot the specifics for why that happens. Regardless, this will clean up the startup process a bunch.
Closes #107
Closes #123
Closes #141
Closes #161
This ended up being bigger than I thought.