Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ChainState: Calculate state root #171

Merged
merged 2 commits into from
Jul 24, 2024
Merged

ChainState: Calculate state root #171

merged 2 commits into from
Jul 24, 2024

Conversation

prajwolrg
Copy link
Contributor

@prajwolrg prajwolrg commented Jul 24, 2024

Resolves #130

Very basic implementation since we may swap out our internal type definitions with SSZ type definitions.

Related:
(WIP) Explore SSZ implementation: https://github.com/alpenlabs/vertex-core/tree/feature/ssz

@prajwolrg prajwolrg requested a review from delbonis July 24, 2024 02:53
@prajwolrg prajwolrg marked this pull request as ready for review July 24, 2024 02:55
Copy link
Contributor

@delbonis delbonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a bad approach. There's an efficiency we could have here from directly hashing while serializing though.

crates/state/src/chain_state.rs Outdated Show resolved Hide resolved
crates/state/src/chain_state.rs Outdated Show resolved Hide resolved
@prajwolrg prajwolrg requested a review from delbonis July 24, 2024 06:44
@delbonis delbonis merged commit f5777cd into master Jul 24, 2024
@storopoli storopoli deleted the 130-chainstate-root branch November 28, 2024 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Impl chainstate root computation
2 participants