Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

consensus-logic: handle missed sync events #206

Merged
merged 5 commits into from
Aug 7, 2024
Merged

Conversation

voidash
Copy link
Contributor

@voidash voidash commented Aug 5, 2024

Description

handle missed sync events when client state worker receives new EventInput

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

Closes #139

Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 35 lines in your changes missing coverage. Please review.

Project coverage is 52.27%. Comparing base (5ea528a) to head (c12f873).
Report is 31 commits behind head on master.

Files Patch % Lines
crates/consensus-logic/src/worker.rs 0.00% 35 Missing ⚠️
@@            Coverage Diff             @@
##           master     #206      +/-   ##
==========================================
- Coverage   53.79%   52.27%   -1.53%     
==========================================
  Files          86       87       +1     
  Lines        7725     8456     +731     
==========================================
+ Hits         4156     4420     +264     
- Misses       3569     4036     +467     
Files Coverage Δ
crates/consensus-logic/src/worker.rs 0.00% <0.00%> (ø)

... and 33 files with indirect coverage changes

@voidash voidash marked this pull request as ready for review August 5, 2024 08:35
@voidash voidash force-pushed the fix/missed-sync-events branch from effaef7 to d2d1942 Compare August 5, 2024 08:43
Copy link
Contributor

@delbonis delbonis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good overall. Good on adding the test.

crates/consensus-logic/src/worker.rs Outdated Show resolved Hide resolved
@voidash voidash requested a review from delbonis August 6, 2024 15:56
@delbonis delbonis merged commit 097d876 into master Aug 7, 2024
7 of 8 checks passed
@delbonis
Copy link
Contributor

delbonis commented Aug 7, 2024

Minor changes, bypassing approval requirements.

@storopoli storopoli deleted the fix/missed-sync-events branch November 28, 2024 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check for missed sync events when client state worker receives new EventInput
2 participants