Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: make clean-dd visible in make #242

Merged
merged 1 commit into from
Aug 22, 2024

Conversation

storopoli
Copy link
Member

@storopoli storopoli commented Aug 21, 2024

Description

I think we should have clean-dd visible in make.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

None. just out of the blue

I think we should have `clean-dd` visible in `make`.
@storopoli storopoli requested a review from Rajil1213 August 21, 2024 23:19
Copy link

codecov bot commented Aug 21, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 54.15%. Comparing base (1485d2e) to head (44e513a).
Report is 2 commits behind head on master.

@@           Coverage Diff           @@
##           master     #242   +/-   ##
=======================================
  Coverage   54.15%   54.15%           
=======================================
  Files         111      111           
  Lines       11964    11964           
=======================================
  Hits         6479     6479           
  Misses       5485     5485           

Copy link
Contributor

@Rajil1213 Rajil1213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

This was not "exposed" because the only time we'd need to do this is when we run functional tests. So, I added it as a pre-requisite for the test-functional recipe. I guess there is a case for wanting to remove the directory after running the tests too.

@Rajil1213 Rajil1213 merged commit 194e274 into master Aug 22, 2024
15 checks passed
@storopoli storopoli deleted the storopoli/makefile-improvements branch August 22, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants