-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add import ordering rule #255
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## master #255 +/- ##
==========================================
- Coverage 57.94% 57.91% -0.03%
==========================================
Files 119 119
Lines 13425 13425
==========================================
- Hits 7779 7775 -4
- Misses 5646 5650 +4
|
Rajil1213
requested changes
Aug 27, 2024
Rajil1213
requested changes
Aug 27, 2024
voidash
force-pushed
the
chore/import-ordering
branch
from
August 27, 2024 06:44
a8c2e05
to
4f160df
Compare
Rajil1213
reviewed
Aug 27, 2024
Co-authored-by: Rajil Bajracharya <[email protected]>
Rajil1213
approved these changes
Aug 27, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good now.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Following import order will be enforced by rustfmt with
StdExternalCrate
on rustfmtcontributing.md
is now a different fileType of Change
Checklist
Related Issues