Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: add import ordering rule #255

Merged
merged 4 commits into from
Aug 27, 2024
Merged

chore: add import ordering rule #255

merged 4 commits into from
Aug 27, 2024

Conversation

voidash
Copy link
Contributor

@voidash voidash commented Aug 27, 2024

Description

Following import order will be enforced by rustfmt with StdExternalCrate on rustfmt

  1. std, core
  2. external crate
  3. self, super, crate import

contributing.md is now a different file

Type of Change

  • Chore

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

Copy link

codecov bot commented Aug 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 57.91%. Comparing base (6d4bd56) to head (493d9d3).
Report is 7 commits behind head on master.

@@            Coverage Diff             @@
##           master     #255      +/-   ##
==========================================
- Coverage   57.94%   57.91%   -0.03%     
==========================================
  Files         119      119              
  Lines       13425    13425              
==========================================
- Hits         7779     7775       -4     
- Misses       5646     5650       +4     
Files Coverage Δ
crates/btcio/src/broadcaster/handle.rs 0.00% <ø> (ø)
crates/btcio/src/broadcaster/task.rs 86.71% <ø> (ø)
crates/btcio/src/reader/query.rs 0.00% <ø> (ø)
crates/btcio/src/rpc/client.rs 0.00% <ø> (ø)
crates/btcio/src/rpc/types.rs 80.32% <ø> (ø)
crates/btcio/src/status.rs 0.00% <ø> (ø)
crates/btcio/src/writer/broadcast.rs 0.00% <ø> (ø)
crates/btcio/src/writer/builder.rs 95.63% <ø> (ø)
crates/btcio/src/writer/config.rs 0.00% <ø> (ø)
crates/btcio/src/writer/utils.rs 86.53% <ø> (ø)
... and 70 more

... and 1 file with indirect coverage changes

Contributing.md Outdated Show resolved Hide resolved
Contributing.md Outdated Show resolved Hide resolved
Contributing.md Outdated Show resolved Hide resolved
@voidash voidash force-pushed the chore/import-ordering branch from a8c2e05 to 4f160df Compare August 27, 2024 06:44
CONTRIBUTING.md Outdated Show resolved Hide resolved
Co-authored-by: Rajil Bajracharya <[email protected]>
Copy link
Contributor

@Rajil1213 Rajil1213 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good now.

@voidash voidash merged commit 538be4d into master Aug 27, 2024
15 checks passed
@storopoli storopoli deleted the chore/import-ordering branch August 27, 2024 08:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants