Consensus worker task impl #34
Conversation
delbonis
force-pushed
the
feature/consensus-loop
branch
2 times, most recently
from
257c55c to
35b387c
Compare
…tegrating some credential checking, etc
delbonis
force-pushed
the
feature/consensus-loop
branch
2 times, most recently
from
2e8be28 to
aa36fb8
Compare
delbonis
force-pushed
the
feature/consensus-loop
branch
from
aa36fb8 to
e1f6be6
Compare
| fn process_ct_msg<D: Database, E: ExecEngineCtl>( | ||
| ctm: ChainTipMessage, |
There was a problem hiding this comment.
I think the function and args are quit abbreviated: what do you think of process_chaintip_message(message: ChainTipMessage...)?
There was a problem hiding this comment.
Will make naming changes in another cleanup pass, there's also too many things that are "trackers".
| // Insert block into pending block tracker and figure out if we | ||
| // should switch to it as a potential head. This returns if we | ||
| // created a new tip instead of advancing an existing tip. | ||
| let cur_tip = cstate.chain_state().chain_tip_blockid(); |
There was a problem hiding this comment.
I thought this would be same as csstate.finalized_tip. What's the difference?
There was a problem hiding this comment.
Finalized is what's been proven on chain. The current tip is where we expect new blocks to be attached and what we treat as the current state. We take it out here since we need to figure out after attaching the block to the pending blocks tree if we're going to switch from the current block to that and how. This is still a bit unfinished and we'll have more sophisticated logic after we've figured out the rest of the block signing mechanics.
| params: Arc<Params>, | ||
|
|
||
| /// Underlying database hierarchy that writes ultimately end up on. | ||
| // TODO should we move this out? | ||
| database: Arc<D>, |
There was a problem hiding this comment.
params and database could be out I guess. As I understand, params will be constant during the worker running and is not specific to worker itself.
There was a problem hiding this comment.
Still reworking this, I'm planning on a type that specifically manages the current state and splits up the data some more. Not going to act on any of this yet until it's time for more general cleanup.
This is just a skeleton, there's some stuff coming from earlier PRs dripping into this PR. Will rebase.
Resolves: #16