Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

backport: print strata explorer links if configured (#453) #454

Merged
merged 1 commit into from
Nov 6, 2024

Conversation

storopoli
Copy link
Member

@storopoli storopoli commented Nov 5, 2024

Description

Backport strata-cli feature to show blockscout links to withdraw transactions.

Blocked by https://github.com/alpenlabs/private-docs/pull/51

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

STR-554

* feat: print strata explorer links if configured

* fix: don't rename the file name for bitcoin explorer
@storopoli storopoli requested a review from sapinb November 5, 2024 12:28
@storopoli storopoli self-assigned this Nov 5, 2024
@storopoli storopoli changed the title feat: print strata explorer links if configured (#453) backport: print strata explorer links if configured (#453) Nov 5, 2024
Copy link

codecov bot commented Nov 5, 2024

Codecov Report

Attention: Patch coverage is 0% with 38 lines in your changes missing coverage. Please review.

Project coverage is 56.92%. Comparing base (a14d926) to head (5c1b260).
Report is 32 commits behind head on releases/0.1.0.

Files with missing lines Patch % Lines
bin/strata-cli/src/strata.rs 0.00% 12 Missing ⚠️
bin/strata-cli/src/signet.rs 0.00% 11 Missing ⚠️
bin/strata-cli/src/cmd/drain.rs 0.00% 4 Missing ⚠️
bin/strata-cli/src/settings.rs 0.00% 4 Missing ⚠️
bin/strata-cli/src/cmd/faucet.rs 0.00% 2 Missing ⚠️
bin/strata-cli/src/cmd/send.rs 0.00% 2 Missing ⚠️
bin/strata-cli/src/cmd/withdraw.rs 0.00% 2 Missing ⚠️
bin/strata-cli/src/cmd/deposit.rs 0.00% 1 Missing ⚠️
@@                Coverage Diff                 @@
##           releases/0.1.0     #454      +/-   ##
==================================================
- Coverage           57.16%   56.92%   -0.25%     
==================================================
  Files                 256      263       +7     
  Lines               27048    28017     +969     
==================================================
+ Hits                15462    15948     +486     
- Misses              11586    12069     +483     
Files with missing lines Coverage Δ
bin/strata-cli/src/cmd/deposit.rs 0.00% <0.00%> (ø)
bin/strata-cli/src/cmd/faucet.rs 0.00% <0.00%> (ø)
bin/strata-cli/src/cmd/send.rs 0.00% <0.00%> (ø)
bin/strata-cli/src/cmd/withdraw.rs 0.00% <0.00%> (ø)
bin/strata-cli/src/cmd/drain.rs 0.00% <0.00%> (ø)
bin/strata-cli/src/settings.rs 0.00% <0.00%> (ø)
bin/strata-cli/src/signet.rs 0.00% <0.00%> (ø)
bin/strata-cli/src/strata.rs 0.00% <0.00%> (ø)

... and 25 files with indirect coverage changes

@Zk2u
Copy link
Contributor

Zk2u commented Nov 5, 2024

Not blocked, this is non breaking and can be merged before docs merge

@storopoli
Copy link
Member Author

Alright let's wait for @sapinb to have a look. This should be a squash merge as always with releases/ branches

@storopoli
Copy link
Member Author

Ok I'm merging this

@storopoli storopoli merged commit e016463 into releases/0.1.0 Nov 6, 2024
16 of 17 checks passed
@storopoli storopoli deleted the backport/strata-cli-blockscout-link branch November 6, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants