Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

applied patch from STR-440-opentelemetry-output #473

Merged
merged 1 commit into from
Nov 14, 2024

Conversation

storopoli
Copy link
Member

@storopoli storopoli commented Nov 14, 2024

Description

This PR is just applying the patch from #342 onto the release branch.

It does build and test correctly.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

* common: tried to set up otlp

This deletes Cargo.lock because we couldn't get the deps to work anyways.

* fix: bump opentelemetry stuff to 0.26

now it compiles at least-ish

* common: added more correct init for OTLP tracing output

* common, contrib: fixed some more logging stuff, added Jaeger util script

* common, stratad: reworked logging init some more to try to make it work

* contrib: fixed Jaeger init script to use a recent version

* bridge-client: fixed broken test, fixed Tokio version

* common: added `service.name` property to OTLP params

* prover-client: fixed missing `LoggerConfig`

* stratad: fixed broken tests??? idk why this is here

* tests: fixed broken logging

* btcio: fixed broken logging

---------

Co-authored-by: Jose Storopoli <[email protected]>
@storopoli
Copy link
Member Author

Superseds #472

@storopoli storopoli requested a review from delbonis November 14, 2024 18:05
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

Attention: Patch coverage is 35.00000% with 65 lines in your changes missing coverage. Please review.

Project coverage is 56.80%. Comparing base (a14d926) to head (c971366).
Report is 34 commits behind head on releases/0.1.0.

Files with missing lines Patch % Lines
crates/common/src/logging.rs 43.07% 37 Missing ⚠️
bin/strata-client/src/main.rs 0.00% 27 Missing ⚠️
bin/bridge-client/src/main.rs 0.00% 1 Missing ⚠️
@@                Coverage Diff                 @@
##           releases/0.1.0     #473      +/-   ##
==================================================
- Coverage           57.16%   56.80%   -0.37%     
==================================================
  Files                 256      263       +7     
  Lines               27048    28116    +1068     
==================================================
+ Hits                15462    15970     +508     
- Misses              11586    12146     +560     
Files with missing lines Coverage Δ
bin/bridge-client/src/descriptor.rs 49.52% <100.00%> (+0.98%) ⬆️
bin/strata-client/src/extractor.rs 96.08% <100.00%> (-0.45%) ⬇️
crates/btcio/src/rpc/client.rs 88.50% <100.00%> (+0.03%) ⬆️
bin/bridge-client/src/main.rs 0.00% <0.00%> (ø)
bin/strata-client/src/main.rs 0.00% <0.00%> (ø)
crates/common/src/logging.rs 44.77% <43.07%> (-55.23%) ⬇️

... and 29 files with indirect coverage changes

@storopoli storopoli enabled auto-merge (squash) November 14, 2024 18:29
@storopoli storopoli merged commit 9c45b61 into releases/0.1.0 Nov 14, 2024
16 of 17 checks passed
@storopoli storopoli deleted the STR-440-p3 branch November 14, 2024 18:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants