Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update reth to v1.1.5 #645

Merged
merged 12 commits into from
Feb 1, 2025
Merged

Update reth to v1.1.5 #645

merged 12 commits into from
Feb 1, 2025

Conversation

prajwolrg
Copy link
Contributor

Description

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

@prajwolrg prajwolrg changed the title Chore/update reth Update reth to v1.1.5 Feb 1, 2025
storopoli
storopoli previously approved these changes Feb 1, 2025
Copy link
Member

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK f45f72b

Thanks! Fixes the new RUSTSEC for cargo-audit on fast-float.

Ref: https://rustsec.org/advisories/RUSTSEC-2025-0003

Copy link

codecov bot commented Feb 1, 2025

Codecov Report

Attention: Patch coverage is 4.68750% with 61 lines in your changes missing coverage. Please review.

Project coverage is 54.86%. Comparing base (67a711d) to head (635fc6b).
Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
crates/reth/node/src/payload_builder.rs 0.00% 30 Missing ⚠️
crates/reth/node/src/engine.rs 0.00% 7 Missing ⚠️
crates/reth/node/src/evm.rs 0.00% 6 Missing ⚠️
crates/reth/node/src/node.rs 0.00% 5 Missing ⚠️
crates/evmexec/src/http_client.rs 0.00% 4 Missing ⚠️
crates/reth/exex/src/prover_exex.rs 0.00% 3 Missing ⚠️
crates/reth/exex/src/cache_db_provider.rs 0.00% 2 Missing ⚠️
crates/reth/rpc/src/eth/transaction.rs 0.00% 2 Missing ⚠️
crates/reth/rpc/src/eth/block.rs 0.00% 1 Missing ⚠️
crates/reth/rpc/src/eth/pending_block.rs 0.00% 1 Missing ⚠️
@@            Coverage Diff             @@
##             main     #645      +/-   ##
==========================================
- Coverage   55.15%   54.86%   -0.30%     
==========================================
  Files         311      313       +2     
  Lines       33321    33460     +139     
==========================================
- Hits        18379    18357      -22     
- Misses      14942    15103     +161     
Files with missing lines Coverage Δ
crates/evmexec/src/el_payload.rs 98.64% <100.00%> (+0.01%) ⬆️
crates/evmexec/src/engine.rs 66.16% <ø> (-0.15%) ⬇️
crates/reth/node/src/payload.rs 6.25% <ø> (ø)
crates/reth/rpc/src/eth/call.rs 0.00% <ø> (ø)
crates/reth/rpc/src/eth/mod.rs 0.00% <ø> (ø)
crates/reth/rpc/src/eth/block.rs 0.00% <0.00%> (ø)
crates/reth/rpc/src/eth/pending_block.rs 0.00% <0.00%> (ø)
crates/reth/exex/src/cache_db_provider.rs 0.00% <0.00%> (ø)
crates/reth/rpc/src/eth/transaction.rs 0.00% <0.00%> (ø)
crates/reth/exex/src/prover_exex.rs 0.00% <0.00%> (ø)
... and 5 more

... and 33 files with indirect coverage changes

@prajwolrg prajwolrg marked this pull request as ready for review February 1, 2025 08:48
@prajwolrg prajwolrg requested review from a team as code owners February 1, 2025 08:48
Copy link
Contributor

github-actions bot commented Feb 1, 2025

Commit: 474ce82

SP1 Performance Test Results

program cycles success
BTC_BLOCKSPACE 30,357,713
EL_BLOCK 98,041
CL_BLOCK 58,268
L1_BATCH 30,387,702
L2_BATCH 5,473
CHECKPOINT 15,255

sapinb
sapinb previously approved these changes Feb 1, 2025
Copy link
Contributor

@evgenyzdanovich evgenyzdanovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for taking care of it! One very minor nit

Cargo.toml Outdated Show resolved Hide resolved
Copy link
Contributor

@evgenyzdanovich evgenyzdanovich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@prajwolrg prajwolrg requested review from storopoli and sapinb February 1, 2025 16:51
@storopoli storopoli enabled auto-merge February 1, 2025 21:04
Copy link
Member

@storopoli storopoli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ACK 635fc6b

@storopoli storopoli added this pull request to the merge queue Feb 1, 2025
Merged via the queue into main with commit 69ab2da Feb 1, 2025
18 of 19 checks passed
@storopoli storopoli deleted the chore/update-reth branch February 1, 2025 21:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants