Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Str 908: Prover client enable import of built ELF #648

Merged
merged 7 commits into from
Feb 5, 2025

Conversation

MdTeach
Copy link
Contributor

@MdTeach MdTeach commented Feb 3, 2025

Description

Introduces an optional feature that allows the prover to run using a prebuilt ELF. With this feature, we can choose to bypass the ELF rebuild process, when running the prover client.

Type of Change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature/Enhancement (non-breaking change which adds functionality or enhances an existing one)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update
  • Refactor
  • New or updated tests
  • Dependency Update

Notes to Reviewers

Checklist

  • I have performed a self-review of my code.
  • I have commented my code where necessary.
  • I have updated the documentation if needed.
  • My changes do not introduce new warnings.
  • I have added tests that prove my changes are effective or that my feature works.
  • New and existing tests pass with my changes.

Related Issues

Copy link

codecov bot commented Feb 3, 2025

Codecov Report

Attention: Patch coverage is 0% with 7 lines in your changes missing coverage. Please review.

Project coverage is 54.81%. Comparing base (9bae5f8) to head (7a5b7b7).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
bin/datatool/src/util.rs 0.00% 7 Missing ⚠️
@@            Coverage Diff             @@
##             main     #648      +/-   ##
==========================================
- Coverage   54.83%   54.81%   -0.03%     
==========================================
  Files         313      313              
  Lines       33526    33526              
==========================================
- Hits        18384    18376       -8     
- Misses      15142    15150       +8     
Files with missing lines Coverage Δ
bin/datatool/src/util.rs 0.00% <0.00%> (ø)

... and 7 files with indirect coverage changes

@MdTeach MdTeach force-pushed the STR-908-pc-load-elf branch 2 times, most recently from 73ab7d5 to 585c81f Compare February 3, 2025 10:22
Copy link
Contributor

github-actions bot commented Feb 3, 2025

Commit: ff63f8f

SP1 Performance Test Results

program cycles success
BTC_BLOCKSPACE 30,357,713
EL_BLOCK 98,041
CL_BLOCK 58,268
L1_BATCH 30,387,702
L2_BATCH 5,473
CHECKPOINT 15,255

@MdTeach MdTeach force-pushed the STR-908-pc-load-elf branch 2 times, most recently from 26af5be to 4b1c3e6 Compare February 3, 2025 16:43
@MdTeach MdTeach force-pushed the STR-908-pc-load-elf branch from 4b1c3e6 to 56afbb6 Compare February 3, 2025 17:13
@MdTeach MdTeach marked this pull request as ready for review February 3, 2025 17:13
@MdTeach MdTeach requested review from a team as code owners February 3, 2025 17:13
delbonis
delbonis previously approved these changes Feb 3, 2025
Copy link
Contributor

@prajwolrg prajwolrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Some nits!

functional-tests/env.bash Outdated Show resolved Hide resolved
functional-tests/tests/prover/prover_el_dispatch.py Outdated Show resolved Hide resolved
provers/sp1/build.rs Show resolved Hide resolved
@MdTeach MdTeach requested a review from delbonis February 5, 2025 15:58
@delbonis delbonis added this pull request to the merge queue Feb 5, 2025
Merged via the queue into main with commit cd9115d Feb 5, 2025
17 of 19 checks passed
@delbonis delbonis deleted the STR-908-pc-load-elf branch February 5, 2025 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants