-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Str 908: Prover client enable import of built ELF #648
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #648 +/- ##
==========================================
- Coverage 54.83% 54.81% -0.03%
==========================================
Files 313 313
Lines 33526 33526
==========================================
- Hits 18384 18376 -8
- Misses 15142 15150 +8
|
MdTeach
force-pushed
the
STR-908-pc-load-elf
branch
2 times, most recently
from
February 3, 2025 10:22
73ab7d5
to
585c81f
Compare
Commit: ff63f8f SP1 Performance Test Results
|
MdTeach
force-pushed
the
STR-908-pc-load-elf
branch
2 times, most recently
from
February 3, 2025 16:43
26af5be
to
4b1c3e6
Compare
MdTeach
force-pushed
the
STR-908-pc-load-elf
branch
from
February 3, 2025 17:13
4b1c3e6
to
56afbb6
Compare
delbonis
previously approved these changes
Feb 3, 2025
prajwolrg
requested changes
Feb 4, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Some nits!
MdTeach
force-pushed
the
STR-908-pc-load-elf
branch
from
February 4, 2025 07:28
56afbb6
to
7a5b7b7
Compare
prajwolrg
approved these changes
Feb 4, 2025
delbonis
approved these changes
Feb 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Introduces an optional feature that allows the prover to run using a prebuilt ELF. With this feature, we can choose to bypass the ELF rebuild process, when running the prover client.
Type of Change
Notes to Reviewers
Checklist
Related Issues