Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Task Engineer #5

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Task Engineer #5

wants to merge 4 commits into from

Conversation

hxuan190
Copy link

First, i saw module github.com/babilu-online/common is unavailable so i built a service context manually.
Second, i see the server will termianted immediately,that is not a best practice for handle shutdown server,so i implemented gracefull shutdown.
Third, i realize that when increase workload, this repo become difficult to maintain,so we need apply architecture and i choose Hexagonal for this, clean structure to easy maintain
Fourth, all service in this project is being used directly,that mean difficult to maintain code and violates the D principle in SOLID,so i used Dependency Injection between layers like transport,usecase,repository.make components become loose coupling. Init service by Constructor, make extension func

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant