-
Notifications
You must be signed in to change notification settings - Fork 11
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add standard header to protect .rubocop.yml #2411
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is intended to be an exemplar that we will later roll out to other GOV.UK repos.
ChrisBAshton
approved these changes
Oct 20, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
huwd
approved these changes
Nov 2, 2021
benthorner
pushed a commit
to alphagov/specialist-publisher
that referenced
this pull request
Nov 9, 2021
https://trello.com/c/Cr2TnMtI/193-make-it-easier-to-agree-with-rubocop-govuk This follows the convention established in [1]. [1]: alphagov/content-publisher#2411
benthorner
pushed a commit
to alphagov/travel-advice-publisher
that referenced
this pull request
Nov 9, 2021
https://trello.com/c/Cr2TnMtI/193-make-it-easier-to-agree-with-rubocop-govuk This follows the convention established in [1]. [1]: alphagov/content-publisher#2411
benthorner
pushed a commit
to alphagov/router-api
that referenced
this pull request
Nov 9, 2021
https://trello.com/c/Cr2TnMtI/193-make-it-easier-to-agree-with-rubocop-govuk This follows the convention established in [1]. [1]: alphagov/content-publisher#2411
benthorner
pushed a commit
to alphagov/maslow
that referenced
this pull request
Nov 9, 2021
https://trello.com/c/Cr2TnMtI/193-make-it-easier-to-agree-with-rubocop-govuk This follows the convention established in [1]. [1]: alphagov/content-publisher#2411
benthorner
pushed a commit
to alphagov/release
that referenced
this pull request
Nov 9, 2021
https://trello.com/c/Cr2TnMtI/193-make-it-easier-to-agree-with-rubocop-govuk This follows the convention established in [1]. [1]: alphagov/content-publisher#2411
benthorner
pushed a commit
to alphagov/support
that referenced
this pull request
Nov 9, 2021
https://trello.com/c/Cr2TnMtI/193-make-it-easier-to-agree-with-rubocop-govuk This follows the convention established in [1]. [1]: alphagov/content-publisher#2411
benthorner
pushed a commit
to alphagov/short-url-manager
that referenced
this pull request
Nov 9, 2021
https://trello.com/c/Cr2TnMtI/193-make-it-easier-to-agree-with-rubocop-govuk This follows the convention established in [1]. [1]: alphagov/content-publisher#2411
benthorner
pushed a commit
to alphagov/search-admin
that referenced
this pull request
Nov 9, 2021
https://trello.com/c/Cr2TnMtI/193-make-it-easier-to-agree-with-rubocop-govuk This follows the convention established in [1]. [1]: alphagov/content-publisher#2411
benthorner
pushed a commit
to alphagov/government-frontend
that referenced
this pull request
Nov 9, 2021
https://trello.com/c/Cr2TnMtI/193-make-it-easier-to-agree-with-rubocop-govuk This follows the convention established in [1]. [1]: alphagov/content-publisher#2411
benthorner
pushed a commit
to alphagov/datagovuk_publish
that referenced
this pull request
Nov 9, 2021
https://trello.com/c/Cr2TnMtI/193-make-it-easier-to-agree-with-rubocop-govuk This follows the convention established in [1]. [1]: alphagov/content-publisher#2411
benthorner
pushed a commit
to alphagov/collections
that referenced
this pull request
Nov 9, 2021
https://trello.com/c/Cr2TnMtI/193-make-it-easier-to-agree-with-rubocop-govuk This follows the convention established in [1]. [1]: alphagov/content-publisher#2411
benthorner
pushed a commit
to alphagov/email-alert-frontend
that referenced
this pull request
Nov 9, 2021
https://trello.com/c/Cr2TnMtI/193-make-it-easier-to-agree-with-rubocop-govuk This follows the convention established in [1]. [1]: alphagov/content-publisher#2411
benthorner
pushed a commit
to alphagov/contacts-admin
that referenced
this pull request
Nov 9, 2021
https://trello.com/c/Cr2TnMtI/193-make-it-easier-to-agree-with-rubocop-govuk This follows the convention established in [1]. [1]: alphagov/content-publisher#2411
benthorner
pushed a commit
to alphagov/frontend
that referenced
this pull request
Nov 9, 2021
https://trello.com/c/Cr2TnMtI/193-make-it-easier-to-agree-with-rubocop-govuk This follows the convention established in [1]. [1]: alphagov/content-publisher#2411
benthorner
pushed a commit
to alphagov/smart-answers
that referenced
this pull request
Nov 9, 2021
https://trello.com/c/Cr2TnMtI/193-make-it-easier-to-agree-with-rubocop-govuk This follows the convention established in [1]. [1]: alphagov/content-publisher#2411
benthorner
pushed a commit
to alphagov/search-api
that referenced
this pull request
Nov 9, 2021
https://trello.com/c/Cr2TnMtI/193-make-it-easier-to-agree-with-rubocop-govuk This follows the convention established in [1]. [1]: alphagov/content-publisher#2411
benthorner
pushed a commit
to alphagov/govuk-developer-docs
that referenced
this pull request
Nov 9, 2021
This is so we maintain this convention [1] in new repos. [1]: alphagov/content-publisher#2411
benthorner
pushed a commit
to alphagov/datagovuk_find
that referenced
this pull request
Nov 9, 2021
This follows the convention established in [1]. [1]: alphagov/content-publisher#2411
benthorner
pushed a commit
to alphagov/info-frontend
that referenced
this pull request
Nov 10, 2021
https://trello.com/c/Cr2TnMtI/193-make-it-easier-to-agree-with-rubocop-govuk This follows the convention established in [1]. [1]: alphagov/content-publisher#2411
benthorner
pushed a commit
to alphagov/places-manager
that referenced
this pull request
Nov 10, 2021
https://trello.com/c/Cr2TnMtI/193-make-it-easier-to-agree-with-rubocop-govuk This follows the convention established in [1]. [1]: alphagov/content-publisher#2411
benthorner
pushed a commit
to alphagov/hmrc-manuals-api
that referenced
this pull request
Nov 10, 2021
https://trello.com/c/Cr2TnMtI/193-make-it-easier-to-agree-with-rubocop-govuk This follows the convention established in [1]. [1]: alphagov/content-publisher#2411
benthorner
pushed a commit
to alphagov/govuk_publishing_components
that referenced
this pull request
Nov 10, 2021
https://trello.com/c/Cr2TnMtI/193-make-it-easier-to-agree-with-rubocop-govuk This follows the convention established in [1]. [1]: alphagov/content-publisher#2411
benthorner
pushed a commit
to alphagov/email-alert-service
that referenced
this pull request
Nov 10, 2021
https://trello.com/c/Cr2TnMtI/193-make-it-easier-to-agree-with-rubocop-govuk This follows the convention established in [1]. [1]: alphagov/content-publisher#2411
benthorner
pushed a commit
to alphagov/collections-publisher
that referenced
this pull request
Nov 10, 2021
https://trello.com/c/Cr2TnMtI/193-make-it-easier-to-agree-with-rubocop-govuk This follows the convention established in [1]. [1]: alphagov/content-publisher#2411
benthorner
pushed a commit
to alphagov/cache-clearing-service
that referenced
this pull request
Nov 10, 2021
https://trello.com/c/Cr2TnMtI/193-make-it-easier-to-agree-with-rubocop-govuk This follows the convention established in [1]. [1]: alphagov/content-publisher#2411
benthorner
pushed a commit
to alphagov/authenticating-proxy
that referenced
this pull request
Nov 10, 2021
https://trello.com/c/Cr2TnMtI/193-make-it-easier-to-agree-with-rubocop-govuk This follows the convention established in [1]. [1]: alphagov/content-publisher#2411
benthorner
pushed a commit
to alphagov/locations-api
that referenced
this pull request
Nov 10, 2021
https://trello.com/c/Cr2TnMtI/193-make-it-easier-to-agree-with-rubocop-govuk This follows the convention established in [1]. [1]: alphagov/content-publisher#2411
benthorner
pushed a commit
to alphagov/bouncer
that referenced
this pull request
Nov 10, 2021
https://trello.com/c/Cr2TnMtI/193-make-it-easier-to-agree-with-rubocop-govuk This follows the convention established in [1]. [1]: alphagov/content-publisher#2411
benthorner
pushed a commit
to alphagov/gds-api-adapters
that referenced
this pull request
Nov 10, 2021
https://trello.com/c/Cr2TnMtI/193-make-it-easier-to-agree-with-rubocop-govuk This follows the convention established in [1]. [1]: alphagov/content-publisher#2411
benthorner
pushed a commit
to alphagov/finder-frontend
that referenced
this pull request
Nov 10, 2021
https://trello.com/c/Cr2TnMtI/193-make-it-easier-to-agree-with-rubocop-govuk This follows the convention established in [1]. [1]: alphagov/content-publisher#2411
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/Cr2TnMtI/193-make-it-easier-to-agree-with-rubocop-govuk
This is intended to be an exemplar that we will later roll out to
other GOV.UK repos.