Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add standard header to protect .rubocop.yml #2411

Merged
merged 1 commit into from
Nov 15, 2021

Conversation

benthorner
Copy link
Contributor

@benthorner benthorner commented Oct 20, 2021

https://trello.com/c/Cr2TnMtI/193-make-it-easier-to-agree-with-rubocop-govuk

This is intended to be an exemplar that we will later roll out to
other GOV.UK repos.

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

This is intended to be an exemplar that we will later roll out to
other GOV.UK repos.
Copy link
Contributor

@ChrisBAshton ChrisBAshton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

benthorner pushed a commit to alphagov/specialist-publisher that referenced this pull request Nov 9, 2021
benthorner pushed a commit to alphagov/travel-advice-publisher that referenced this pull request Nov 9, 2021
benthorner pushed a commit to alphagov/router-api that referenced this pull request Nov 9, 2021
benthorner pushed a commit to alphagov/maslow that referenced this pull request Nov 9, 2021
benthorner pushed a commit to alphagov/release that referenced this pull request Nov 9, 2021
benthorner pushed a commit to alphagov/support that referenced this pull request Nov 9, 2021
benthorner pushed a commit to alphagov/short-url-manager that referenced this pull request Nov 9, 2021
benthorner pushed a commit to alphagov/search-admin that referenced this pull request Nov 9, 2021
benthorner pushed a commit to alphagov/government-frontend that referenced this pull request Nov 9, 2021
benthorner pushed a commit to alphagov/datagovuk_publish that referenced this pull request Nov 9, 2021
benthorner pushed a commit to alphagov/collections that referenced this pull request Nov 9, 2021
benthorner pushed a commit to alphagov/email-alert-frontend that referenced this pull request Nov 9, 2021
benthorner pushed a commit to alphagov/contacts-admin that referenced this pull request Nov 9, 2021
benthorner pushed a commit to alphagov/frontend that referenced this pull request Nov 9, 2021
benthorner pushed a commit to alphagov/smart-answers that referenced this pull request Nov 9, 2021
benthorner pushed a commit to alphagov/search-api that referenced this pull request Nov 9, 2021
benthorner pushed a commit to alphagov/govuk-developer-docs that referenced this pull request Nov 9, 2021
This is so we maintain this convention [1] in new repos.

[1]: alphagov/content-publisher#2411
benthorner pushed a commit to alphagov/datagovuk_find that referenced this pull request Nov 9, 2021
This follows the convention established in [1].

[1]: alphagov/content-publisher#2411
benthorner pushed a commit to alphagov/info-frontend that referenced this pull request Nov 10, 2021
benthorner pushed a commit to alphagov/places-manager that referenced this pull request Nov 10, 2021
benthorner pushed a commit to alphagov/hmrc-manuals-api that referenced this pull request Nov 10, 2021
benthorner pushed a commit to alphagov/govuk_publishing_components that referenced this pull request Nov 10, 2021
benthorner pushed a commit to alphagov/email-alert-service that referenced this pull request Nov 10, 2021
benthorner pushed a commit to alphagov/collections-publisher that referenced this pull request Nov 10, 2021
benthorner pushed a commit to alphagov/cache-clearing-service that referenced this pull request Nov 10, 2021
benthorner pushed a commit to alphagov/authenticating-proxy that referenced this pull request Nov 10, 2021
benthorner pushed a commit to alphagov/locations-api that referenced this pull request Nov 10, 2021
benthorner pushed a commit to alphagov/bouncer that referenced this pull request Nov 10, 2021
benthorner pushed a commit to alphagov/gds-api-adapters that referenced this pull request Nov 10, 2021
benthorner pushed a commit to alphagov/finder-frontend that referenced this pull request Nov 10, 2021
@kevindew kevindew merged commit 033535b into main Nov 15, 2021
@kevindew kevindew deleted the add-standard-rubocop-header branch November 15, 2021 10:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants