-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump rails from 7.2.2.1 to 8.0.1 #1366
Conversation
This application is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs. Follow these steps if you are doing a Rails upgrade. |
5794871
to
43d7607
Compare
688df4d
to
8fac10a
Compare
3e49bce
to
4212878
Compare
Bumps [rails](https://github.com/rails/rails) from 7.2.2.1 to 8.0.1. - [Release notes](https://github.com/rails/rails/releases) - [Commits](rails/rails@v7.2.2.1...v8.0.1) --- updated-dependencies: - dependency-name: rails dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]>
4212878
to
5ce5a09
Compare
5ce5a09
to
324208a
Compare
config/environments/test.rb
Outdated
# Raise exceptions for disallowed deprecations. | ||
config.active_support.disallowed_deprecation = :raise | ||
|
||
# Tell Active Support which deprecation messages to disallow. | ||
config.active_support.disallowed_deprecation_warnings = [] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: might be useful to keep these? They were removed from the default config because they thought they'd be less useful for new apps, but I think it would be good to flag this to us
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'll keep these in as these are useful.
-- | ||
-- Name: public; Type: SCHEMA; Schema: -; Owner: - | ||
-- | ||
|
||
-- *not* creating schema, since initdb creates it | ||
|
||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
question: did this just come out of running the update task?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It did indeed. I'm not entirely sure why, since this is just the ouput from pg_dump
. I don't think these comments are important though, as far as I can see.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A bit of Googling suggests it is caused by variations between different versions of PostgreSQL.
This updates configuration for Rails 8. The following have been skipped: - puma configuration, since we use `GovukPuma` - enabling `force_ssl`, since this has previously caused issues in other applications
324208a
to
618592c
Compare
Bumps rails from 7.2.2.1 to 8.0.1.
Release notes
Sourced from rails's releases.
... (truncated)
Commits
cf6ff17
Preparing for 8.0.1 release0bba3c2
Merge pull request #53936 from jsharpify/jsharpify/prism-parsing8521b99
[RF-DOCS] Update Rails Testing Guide [ci skip] (#53872)dbe61a7
Merge pull request #53907 from p8/guides/fix-canonicalf8d559d
[RF-DOCS] Asset Pipeline Documentation (Propshaft) [ci-skip] (#53875)2ae1d69
[RF-DOCS] Solid Cache updates in Caching with Rails: An Overview [ci-skip] (...85bde83
Merge pull request #53926 from Ridhwana/Ridhwana/solid-queuec167cbe
Merge pull request #53941 from byroot/rack-server-protocol656e209
Merge pull request #53940 from mjankowski/rdoc-link-to-add-check-constraintb9608a6
Merge pull request #53937 from fatkodima/mysql-fix-remove-foreign-key-restrictYou can trigger a rebase of this PR by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)Trello card