Tidy for sidekiq 7 #2237
Draft
Tidy for sidekiq 7 #2237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have now upgraded to Sidekiq 7, so don't need to require strict arguments in preparation for switching, as this version includes that requirement by default.
- No other changes in this commit
- `Sidekiq::Worker` has been deprecated in Sidekiq 7, so we need to replace it with `Sidekiq::Job`, and then rename the workers to be jobs in the following commits
- includes renaming the MetricsCollectionWorker directory that houses the individual metrics classes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cleanups for Sidekiq 7 - we're already on Sidekiq 7, but need to rename all the workers, etc.
Follow these steps if you are doing a Rails upgrade.