Skip to content

Commit

Permalink
Merge pull request #3644 from alphagov/remove_format_name
Browse files Browse the repository at this point in the history
Remove unused `format_name` property
  • Loading branch information
ChrisBAshton authored Feb 3, 2025
2 parents d7126a7 + 230f056 commit ba81d3c
Show file tree
Hide file tree
Showing 10 changed files with 0 additions and 16 deletions.
7 changes: 0 additions & 7 deletions docs/finder-content-item.md
Original file line number Diff line number Diff line change
Expand Up @@ -54,13 +54,6 @@ For example, rejecting all documents which don't have a policy would need a hash
}
```

## `format_name`

A string. Optional.

Not specifically used by the Finder. Usually a singularised version of the title of the Finder - `"Competition and Markets Authority case"` for [`/cma-cases`](https://www.gov.uk/cma-cases) for example.
However there are edge cases where it's not the same such as `"Medical safety alert"` for [Alerts and recalls for drugs and medical devices](https://www.gov.uk/drug-device-alerts).

## `default_order`

A string. Optional.
Expand Down
1 change: 0 additions & 1 deletion features/fixtures/aaib_reports_example.json
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,6 @@
"filter":{
"document_type":"aaib_report"
},
"format_name":"Air Accidents Investigation Branch report",
"show_summaries":true,
"facets":[
{
Expand Down
1 change: 0 additions & 1 deletion features/fixtures/all_content.json
Original file line number Diff line number Diff line change
Expand Up @@ -108,7 +108,6 @@
"type": "hidden_clearable"
}
],
"format_name": "Documents",
"reject": {
"link": [
"/search/all"
Expand Down
1 change: 0 additions & 1 deletion features/fixtures/cma_cases_content_item.json
Original file line number Diff line number Diff line change
Expand Up @@ -733,7 +733,6 @@
"filter": {
"document_type": "cma_case"
},
"format_name": "Competition and Markets Authority case",
"show_summaries": false,
"facets": [
{
Expand Down
1 change: 0 additions & 1 deletion features/fixtures/news_and_communications.json
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,6 @@
"filter":{
"content_purpose_subgroup": ["news", "speeches_and_statements"]
},
"format_name":"News or communiqué",
"show_summaries":true,
"sort": [
{
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -46,7 +46,6 @@
"filter":{
"content_purpose_supergroup":"news_and_communications"
},
"format_name":"News or communiqué",
"show_summaries":true,
"sort": [
{
Expand Down
1 change: 0 additions & 1 deletion features/fixtures/official_documents.json
Original file line number Diff line number Diff line change
Expand Up @@ -26,7 +26,6 @@
"filter": {
"has_official_document": true
},
"format_name": "Official documents",
"show_summaries": true,
"sort": [
{
Expand Down
1 change: 0 additions & 1 deletion features/fixtures/policy_and_engagement.json
Original file line number Diff line number Diff line change
Expand Up @@ -58,7 +58,6 @@
"policy_and_engagement"
]
},
"format_name": "document",
"show_summaries": true,
"sort": [
{
Expand Down
1 change: 0 additions & 1 deletion features/fixtures/statistics.json
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,6 @@
"beta_message": "This is in beta. Please take our <a href='https://www.gov.uk'>survey</a>.",
"document_noun":"result",
"filter":{},
"format_name":"statistic",
"show_summaries":true,
"sort": [
{
Expand Down
1 change: 0 additions & 1 deletion spec/support/content_helper.rb
Original file line number Diff line number Diff line change
Expand Up @@ -486,7 +486,6 @@ def example_cma_cases_finder
"filter" => {
"document_type" => "cma_case",
},
"format_name" => "Competition and Markets Authority case",
"show_summaries" => false,
}
finder["links"] = {
Expand Down

0 comments on commit ba81d3c

Please sign in to comment.