Add tables for forms models #1740
Open
+112
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Copies lines 37-48,50-75,85-100 in [forms-api/db/schema.rb] into a new database migration for this app, so that we have the same tables in the forms-admin database. [forms-api/db/schema.rb]: https://github.com/alphagov/forms-api/blob/c1cf1c081020abf779977153fe58f3d73b1af3a8/db/schema.rb
- Remove force: :cascade - Use timestamps shortcut - Use references shortcut - Let Rails choose index name
Ran `bin/rails db:migrate` to get the latest version of the database schema dump.
lfdebrux
force-pushed
the
api-v2/add-tables
branch
from
f0bcfe3 to
11c4d8f
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/xotu6KNy/1995-add-tables-for-form-models-to-forms-admin
We want to migrate the records for forms conditions and pages to this app from forms-api.
This PR adds the tables we'll need in the database.
I've purposely not added models to use those tables, as for now we want the tables to be empty and unused.
Things to consider when reviewing