Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Log Auth0 uid for the callback request after login #1741

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

stephencdaly
Copy link
Contributor

@stephencdaly stephencdaly commented Jan 30, 2025

What problem does this pull request solve?

Trello card: https://trello.com/c/GB7aE55f/2090-spike-investigate-matching-up-auth0-logs-and-forms-admin-application-logs

Log the uid in the omniauth response so that we can link this up to the login events logged by Auth0. Without this, we have no link between the Auth0 logs and our application logs meaning that if Auth0 returns a success login response but we fail to handle it for any reason on our end, we can't match up the 2 sets of logs.

Things to consider when reviewing

  • Ensure that you consider the wider context.
  • Does it work when run on your machine?
  • Is it clear what the code is doing?
  • Do the commit messages explain why the changes were made?
  • Are there all the unit tests needed?
  • Has all relevant documentation been updated?

Log the uid in the omniauth response so that we can link this up to
the login events logged by Auth0. Without this, we have no link
between the Auth0 logs and our application logs meaning that if Auth0
returns a success login response but we fail to handle it for any
reason on our end, we can't match up the 2 sets of logs.
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant