Review apps terraform #1745
Draft
Review apps terraform #1745
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AP-Hunt
force-pushed
the
review-apps-terraform
branch
2 times, most recently
from
ed49a33 to
8a7bdd6
Compare
The .review_apps directory will contain Terraform code for deploying a review copy of forms-admin. For now, it contains Terraform version cofiguration and a small amount of documentation in README.md.
Checks Terraform style and syntax, and lints it with Checkov
PR number will be used to identify and label a number of things in the deployment.
…bucket `integration/review` from `forms-deploy` exports a bunch of values, like subnet ids and security groups, which will be needed by `.review_apps` to deploy to AWS ECS.
AP-Hunt
force-pushed
the
review-apps-terraform
branch
from
4000949 to
635333c
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this pull request solve?
Trello card: https://trello.com/c/u0AOLJYF/579-terraform-for-deploying-forms-admin-to-integration-ecs-cluster
Things to consider when reviewing