Remove Whitehall asset #1220
Merged
Remove Whitehall asset #1220
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yuetylauiris
force-pushed
the
remove-whitehall-asset
branch
3 times, most recently
from
273f4bf to
1717d4d
Compare
yuetylauiris
added a commit
to alphagov/frontend
that referenced
this pull request
Dec 12, 2023
Whitehall assets related endpoints will be soon removed from GDS API adapters (for more context please see this [PR](alphagov/gds-api-adapters#1220) ) so we are cleaning up use cases in this repo. Co-authored-by: Tuomas Nylund <[email protected]>
yuetylauiris
added a commit
to alphagov/frontend
that referenced
this pull request
Dec 12, 2023
Whitehall assets related endpoints will be soon removed from GDS API adapters (for more context please see this [PR](alphagov/gds-api-adapters#1220) ) so we are cleaning up use cases in this repo. Co-authored-by: Tuomas Nylund <[email protected]>
yuetylauiris
force-pushed
the
remove-whitehall-asset
branch
from
1717d4d to
5ecd215
Compare
yuetylauiris
force-pushed
the
remove-whitehall-asset
branch
from
5ecd215 to
359323a
Compare
`Whitehall` app no longer using legacy url now so we can delete the related whitehall_assets methods/helpers/tests. We are keeping the media ones since there are still so use cases of that. For more context please see [this trello card](https://trello.com/c/TREhvM0Q/126-task-upgrade-rake-task-to-modern-asset-endpoint)
yuetylauiris
force-pushed
the
remove-whitehall-asset
branch
from
359323a to
437933e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Whitehallapp no longer using legacy url now so we can delete the related whitehall_assets methods/helpers/tests.We are keeping the media ones since there are still so use cases of that.
This PR is dependent on the frontend csv preview PR as frontend is still using whitehall_asset endpoint.
Trello card