-
Notifications
You must be signed in to change notification settings - Fork 46
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BAU: Update program name #800
Conversation
|
||
### Mandatory | ||
|
||
- `Product`: should be `GOV.UK Sign In` | ||
- `Product`: should be `GOV.UK One Login` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paroxp, could I confirm if we merged that, that I'm not going to break any reports we have.
I think now because the tags I've already seen are a bit of a mess of different names already?
And I know we're about to transition to our own org too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we were to break any reports, which there may be little of, we shouldn't be blocked on iterating on our changes :)
I think we can take the heat, and fix/adjust the reports later if that turns to be an issue.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@deanwilson gonna treat that as a "happy to go" from my program
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@paroxp would you mind giving this a ✅ ?
It's the name we're trying to use everywhere so adding it to be consistent
97a88b7
to
90b6deb
Compare
sorry @paroxp forgot about this one. Just rebased against main, you happy to ✅ and I'll send it out this time? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approving based on previous approvals.
Couple of program clarifications,