Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reverts #835
The naming convention was arrived at through some cross-team collaboration, and was well intentioned, but we've since spotted some issues with it.
For instance, much of the benefit the naming convention would supply is already being supplied by the tagging convention, e.g. the example of
govuk-prod-eu-west-1-eks-signon-01
would already be covered by tags likeGOV.UK
,production
,EKS cluster infrastructure
and so on.Moreover, GOV.UK is not currently using this documented naming convention, so this doc is aspirational only, and therefore slightly misleading.
We've decided to remove the doc and revisit later (when we've had a chance to test out a naming convention on production).
Trello: https://trello.com/c/qn0jHWky/3353-implement-naming