Attempt to fix deployments by tweaking github actions #870
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looking at the README.md for the upload-pages-artifact repo it calls out the file permissions can often be an issue here. https://github.com/actions/upload-pages-artifact?tab=readme-ov-file#file-permissions Note we're using ubuntu-latest for these actions so let's take the Linux permissions fix. Why am I looking at permissions? Here's our failure: https://github.com/alphagov/gds-way/actions/runs/7830155355/job/21363559363 Deploy to GitHubPages calls out: Artifact exchange URL: https://pipelinesghubeus2.actions.githubusercontent.com/Ke52u2ZSbeIIRVMfUZSHU6nygLdHv4s1RfZ82XduCzcNKbxtLt/_apis/pipelines/workflows/7830155355/artifacts?api-version=6.0-preview Which as the suspicious message: ``` message "The user 'System:PublicAccess;aaaaaaaa-aaaa-aaaa-aaaa-aaaaaaaaaaaa' is not authorized to access this resource." ```
Easier to read if you indent a list, and let's use " everywhere
Doing spring cleaning updates whilst I'm here
Doing spring clearning updates whilst here
Doing spring cleaning updates whilst I'm here
DavidBiddle
approved these changes
Feb 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm suspicious that some of our actions aren't acting like they should.
I've updated the deploy artifact action,
Also added a suggested permission fix in from their README (my current main theory here, see commit for why).
Whilst I was there updated others.
It's bundling a few things, but can drop commits if folks disagree.
Would be nice to work with a clean slate of steps that mirror their readmes.