-
Notifications
You must be signed in to change notification settings - Fork 45
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated Dockerfile reference and updated Dockerfile to match guidance #950
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel I don't know how I'd go about updating the Dockerfile, but that's a me problem not necessarily something for the GDS Way to fix. It might want to be in the readme for the repo, but I guess if it's the same in all cases then maybe not.
Do you want me to document how to update the sha of a Dockerfile based on the comment above the FROM? I'll happily do that and I think you're right - it's implicit but it should be more explicit. |
That will be a good addition. Once that is done is this PR ready to be merged? |
0880548
to
2a24ce3
Compare
2a24ce3
to
081effa
Compare
Updated the Dockerfile reference documentation as needed a refresh.
Referencing the OCI so that we can link back to the open standards that we're following, and the reason for following a particular implementation of the open standard.
Updated our ~/Dockerfile to match our guidance regarding sha pinning.