Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated Dockerfile reference and updated Dockerfile to match guidance #950

Merged
merged 11 commits into from
Nov 27, 2024

Conversation

andyloughran
Copy link
Contributor

Updated the Dockerfile reference documentation as needed a refresh.

Referencing the OCI so that we can link back to the open standards that we're following, and the reason for following a particular implementation of the open standard.

Updated our ~/Dockerfile to match our guidance regarding sha pinning.

mrwilson
mrwilson previously approved these changes Oct 23, 2024
@andyloughran andyloughran dismissed mrwilson’s stale review October 23, 2024 16:04

Guidance has changed

Copy link
Contributor

@galund galund left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I feel I don't know how I'd go about updating the Dockerfile, but that's a me problem not necessarily something for the GDS Way to fix. It might want to be in the readme for the repo, but I guess if it's the same in all cases then maybe not.

@andyloughran
Copy link
Contributor Author

I feel I don't know how I'd go about updating the Dockerfile, but that's a me problem not necessarily something for the GDS Way to fix. It might want to be in the readme for the repo, but I guess if it's the same in all cases then maybe not.

Do you want me to document how to update the sha of a Dockerfile based on the comment above the FROM? I'll happily do that and I think you're right - it's implicit but it should be more explicit.

@willp-bl
Copy link
Contributor

I feel I don't know how I'd go about updating the Dockerfile, but that's a me problem not necessarily something for the GDS Way to fix. It might want to be in the readme for the repo, but I guess if it's the same in all cases then maybe not.

Do you want me to document how to update the sha of a Dockerfile based on the comment above the FROM? I'll happily do that and I think you're right - it's implicit but it should be more explicit.

That will be a good addition. Once that is done is this PR ready to be merged?

@galund galund force-pushed the refresh/dockerfile branch from 0880548 to 2a24ce3 Compare November 25, 2024 14:43
@galund galund force-pushed the refresh/dockerfile branch from 2a24ce3 to 081effa Compare November 25, 2024 14:45
@louzoid-gds louzoid-gds merged commit cba58c5 into main Nov 27, 2024
1 check passed
@louzoid-gds louzoid-gds deleted the refresh/dockerfile branch November 27, 2024 11:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants