Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add "overview:" to titles where an attachment has the same name #2238

Merged
merged 1 commit into from
Nov 8, 2021

Conversation

maxgds
Copy link
Contributor

@maxgds maxgds commented Oct 5, 2021

What

We currently have live pages that have attachments that share the exact same title for a number of publications and consultations. This can make for confusing user journeys and in the case of HTML attachments can make it confusing for users of assistive technology navigating between the pages and can disorientate those with cognitive problems. Our solution to the issue to to adjust the parent page title in cases where this happens and add the word "overview". This will affect both the HTML page title (as seen in the browser tab), and the H1 for affected pages. In unaffected pages the H1 contains the name of the document with supporting document type context above it. Where a page is affected that contextual text has "overview:" appended and it is moved inside the H1 tag.

https://trello.com/c/Z3D4CElD/841-update-heading-and-title-pattern-for-publication-and-consultation-pages

Screenshots

Before

image

After

image

Examples

Some affected sample urls used during testing:

https://www.gov.uk/government/publications/warm-home-discount-better-targeted-support-from-2022-cfp-response-to-the-beis-consultation
https://www.gov.uk/government/government/publications/impact-assessment-of-the-mental-capacity-amendment-act-2019
https://www.gov.uk/government/publications/warm-home-discount-better-targeted-support-from-2022-cfp-response-to-the-beis-consultation
https://www.gov.uk/government/government/publications/impact-assessment-of-the-mental-capacity-amendment-act-2019
https://www.gov.uk/government/publications/economic-crime-research-strategy-home-office-research-priorities
https://www.gov.uk/government/publications/civil-procedure-rule-committee-annual-report-2011
https://www.gov.uk/government/publications/national-probation-service-england-and-wales-divisions-map
https://www.gov.uk/government/publications/electric-vehicle-homecharge-scheme-authorised-installers
https://www.gov.uk/government/publications/grade-and-salary-bands
https://www.gov.uk/government/publications/armed-forces-pay-review-body-fiftieth-report-2021
https://www.gov.uk/government/publications/agreement-establishing-an-association-between-the-uk-and-central-america-ms-no322019
https://www.gov.uk/government/publications/notice-143-a-guide-for-international-post-users
https://www.gov.uk/government/publications/general-medical-council
https://www.gov.uk/government/publications/government-functional-standard-govs-001-government-functions
https://www.gov.uk/government/publications/spending-review-2021-launch-letter
https://www.gov.uk/government/publications/staying-legal-heavy-goods-vehicle-drivers
https://www.gov.uk/government/publications/draft-online-safety-bill

https://www.gov.uk/government/consultations/appraisal-periods-consultation
https://www.gov.uk/government/consultations/call-for-evidence-to-inform-orbital-liability-and-insurance-policy

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

@govuk-ci govuk-ci temporarily deployed to government-f-context-ov-c8ctco October 5, 2021 07:56 Inactive
@govuk-ci govuk-ci temporarily deployed to government-f-context-ov-c8ctco October 5, 2021 07:58 Inactive
@maxgds maxgds force-pushed the context-overview branch 7 times, most recently from e7c43f0 to d64e6c2 Compare October 26, 2021 14:53
@maxgds maxgds changed the title wip Add "overview" to titles where an attachment has the same name Oct 26, 2021
@maxgds maxgds changed the title Add "overview" to titles where an attachment has the same name Add "overview:" to titles where an attachment has the same name Oct 26, 2021
@maxgds maxgds marked this pull request as ready for review October 26, 2021 15:29
Copy link
Contributor

@jon-kirwan jon-kirwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of smallish comments / suggestions but it's looking good 👍

app/views/content_items/consultation.html.erb Outdated Show resolved Hide resolved
app/views/content_items/publication.html.erb Outdated Show resolved Hide resolved
app/views/content_items/_context_and_title.html.erb Outdated Show resolved Hide resolved
Copy link
Contributor

@jon-kirwan jon-kirwan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@maxgds maxgds merged commit ae08702 into main Nov 8, 2021
@maxgds maxgds deleted the context-overview branch November 8, 2021 15:59
maxgds added a commit that referenced this pull request Dec 8, 2021
maxgds added a commit that referenced this pull request Dec 8, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants