-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add "overview:" to titles where an attachment has the same name #2238
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
e7c43f0
to
d64e6c2
Compare
d64e6c2
to
dbc59af
Compare
jon-kirwan
reviewed
Oct 28, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a couple of smallish comments / suggestions but it's looking good 👍
dbc59af
to
1a4b807
Compare
jon-kirwan
approved these changes
Nov 8, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
1a4b807
to
996a1ce
Compare
maxgds
added a commit
that referenced
this pull request
Dec 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
We currently have live pages that have attachments that share the exact same title for a number of publications and consultations. This can make for confusing user journeys and in the case of HTML attachments can make it confusing for users of assistive technology navigating between the pages and can disorientate those with cognitive problems. Our solution to the issue to to adjust the parent page title in cases where this happens and add the word "overview". This will affect both the HTML page title (as seen in the browser tab), and the H1 for affected pages. In unaffected pages the H1 contains the name of the document with supporting document type context above it. Where a page is affected that contextual text has "overview:" appended and it is moved inside the H1 tag.
https://trello.com/c/Z3D4CElD/841-update-heading-and-title-pattern-for-publication-and-consultation-pages
Screenshots
Before
After
Examples
Some affected sample urls used during testing:
https://www.gov.uk/government/publications/warm-home-discount-better-targeted-support-from-2022-cfp-response-to-the-beis-consultation
https://www.gov.uk/government/government/publications/impact-assessment-of-the-mental-capacity-amendment-act-2019
https://www.gov.uk/government/publications/warm-home-discount-better-targeted-support-from-2022-cfp-response-to-the-beis-consultation
https://www.gov.uk/government/government/publications/impact-assessment-of-the-mental-capacity-amendment-act-2019
https://www.gov.uk/government/publications/economic-crime-research-strategy-home-office-research-priorities
https://www.gov.uk/government/publications/civil-procedure-rule-committee-annual-report-2011
https://www.gov.uk/government/publications/national-probation-service-england-and-wales-divisions-map
https://www.gov.uk/government/publications/electric-vehicle-homecharge-scheme-authorised-installers
https://www.gov.uk/government/publications/grade-and-salary-bands
https://www.gov.uk/government/publications/armed-forces-pay-review-body-fiftieth-report-2021
https://www.gov.uk/government/publications/agreement-establishing-an-association-between-the-uk-and-central-america-ms-no322019
https://www.gov.uk/government/publications/notice-143-a-guide-for-international-post-users
https://www.gov.uk/government/publications/general-medical-council
https://www.gov.uk/government/publications/government-functional-standard-govs-001-government-functions
https://www.gov.uk/government/publications/spending-review-2021-launch-letter
https://www.gov.uk/government/publications/staying-legal-heavy-goods-vehicle-drivers
https://www.gov.uk/government/publications/draft-online-safety-bill
https://www.gov.uk/government/consultations/appraisal-periods-consultation
https://www.gov.uk/government/consultations/call-for-evidence-to-inform-orbital-liability-and-insurance-policy