-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add translations from ASP #2285
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit imports the original translation locales from ASP [1]. `bundle exec rake translation:import:all`. [1]: https://www.theapsgroup.com/en-gb/
Certain locale files from the translation supplier belong to a different application and so have been reverted.
Renames the text keys and adds link.
We now have a pretty complete set of translations, and so we need to use a stub instead of the actual locale files for testing the fallback behaviour.
Prevents raw HTML being rendered if not taken care of in the application code.
`bundle exec rake translation:normalize`
ed98456
to
5be83c6
Compare
Adds config to skip certain keys from being considered as 'unused' by i18n-tasks.
`bundle exec i18n-tasks remove-unsued`
`bundle exec rake translation:add_missing`
5be83c6
to
1228856
Compare
deborahchua
approved these changes
Nov 15, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the translations which were provided by ASP. As it has been quite a while since we sent off the locales, there has been a decent amount of cleanup to fit them in to our current locale structure, e.g. renaming, adding and removing keys.
There are a few languages that we're still waiting on form the supplier, including: gu, ka, ms, pt, ro, ru, sk, sl, ur.
Trello:
https://trello.com/c/Xz78vNR4/2757-import-newly-sourced-translations-into-locale-files-5