Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add translations from ASP #2285

Merged
merged 11 commits into from
Nov 15, 2021
Merged

Add translations from ASP #2285

merged 11 commits into from
Nov 15, 2021

Conversation

1pretz1
Copy link
Contributor

@1pretz1 1pretz1 commented Nov 15, 2021

This PR adds the translations which were provided by ASP. As it has been quite a while since we sent off the locales, there has been a decent amount of cleanup to fit them in to our current locale structure, e.g. renaming, adding and removing keys.

There are a few languages that we're still waiting on form the supplier, including: gu, ka, ms, pt, ro, ru, sk, sl, ur.

Trello:
https://trello.com/c/Xz78vNR4/2757-import-newly-sourced-translations-into-locale-files-5

⚠️ This repo is Continuously Deployed: make sure you follow the guidance ⚠️

This commit imports the original translation locales from ASP [1].

`bundle exec rake translation:import:all`.

[1]: https://www.theapsgroup.com/en-gb/
Certain locale files from the translation supplier belong to a
different application and so have been reverted.
Renames the text keys and adds link.
@govuk-ci govuk-ci temporarily deployed to government-f-add-transl-vauzau November 15, 2021 12:38 Inactive
We now have a pretty complete set of translations, and so we need to use
a stub instead of the actual locale files for testing the fallback
behaviour.
Prevents raw HTML being rendered if not taken care of in the application
code.
`bundle exec rake translation:normalize`
@govuk-ci govuk-ci temporarily deployed to government-f-add-transl-vauzau November 15, 2021 12:51 Inactive
Adds config to skip certain keys from being considered as 'unused' by
i18n-tasks.
`bundle exec i18n-tasks remove-unsued`
`bundle exec rake translation:add_missing`
@govuk-ci govuk-ci temporarily deployed to government-f-add-transl-vauzau November 15, 2021 13:47 Inactive
Copy link
Contributor

@deborahchua deborahchua left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@1pretz1 1pretz1 merged commit 97564db into main Nov 15, 2021
@1pretz1 1pretz1 deleted the add-translations branch November 15, 2021 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants