Ensure data-module is a valid attribute for buttons, Don't match button for inline or indentations #116
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I made a mistake by not including proper test coverage of the validation of this new feature. This fixes the mistake and adds the correct tests that should have caught this earlier.
In order to display this govspeak in our guide we want to be able to indent it, but due to how this regex works, this is not possible. Now buttons will only be matched when they're not indented or inline within text.
NickColley
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I made a mistake by not including proper test coverage of the validation of this new feature.
This fixes the mistake and adds the correct tests that should have caught this earlier.
This also makes sure that buttons are only matched when not indented, which will make it easy to include this govspeak in guides.
https://trello.com/c/ppqXaGPk/122-create-a-govspeak-component-for-buttons