Fix footnotes to work within call-to-action boxes. #222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjamineskola
approved these changes
Oct 22, 2021
There was a problem hiding this comment.
This looks great - thanks @baisa 👏
Just a couple of suggestions on the contents of the tests.
| footnotes = source.scan(/\[\^(\d+)\]:(.*)/) | ||
| @acronyms = source.scan(/(?<=\*)\[(.*)\]:(.*)/) | ||
|
|
||
| if is_legislative_list && footnotes.size.positive? | ||
| if (is_legislative_list || is_cta) && footnotes.size.positive? |
There was a problem hiding this comment.
I like how you've reused the existing logic 👍
baisa
force-pushed
the
Footnotes-in-call-to-action-boxes
branch
from
6196bd3 to
17b72e6
Compare
We need to parse footnotes when they appear in $CTA call-to-action boxes as currently they appear as markdown. Added tests.
baisa
force-pushed
the
Footnotes-in-call-to-action-boxes
branch
from
17b72e6 to
c3f1213
Compare
ChrisBAshton
approved these changes
Nov 2, 2021
baisa
force-pushed
the
Footnotes-in-call-to-action-boxes
branch
from
c3f1213 to
43c1ad4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trello card
What
We need to parse footnotes when they appear in $CTA call-to-action boxes. Currently they appear as markdown ([^1]).
Why
In call to action boxes ($CTA), footnotes don't work and are just shown as markdown - [^1] - meaning for some publications where there's a need to use GOV.UK patterns to replicate some styling in a printed publication isn't possible.