Add draggable false to button markup and validation #224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
owenatgov
force-pushed
the
draggable-false-on-buttons
branch
from
b063d76 to
390ba29
Compare
karlbaker02
reviewed
Nov 19, 2021
| @@ -224,7 +224,7 @@ def insert_strong_inside_p(body, parser = Govspeak::Document) | |||
| text = text.strip | |||
| href = href.strip | |||
|
|
|||
| %(\n<a role="button" class="#{button_classes}" href="#{href}" #{data_attribute}>#{text}</a>\n) | |||
| %(\n<a role="button" draggable="false" class="#{button_classes}" href="#{href}" #{data_attribute}>#{text}</a>\n) | |||
There was a problem hiding this comment.
We still need draggable="false" here right?
There was a problem hiding this comment.
After a very quick test, we indeed do.
owenatgov
force-pushed
the
draggable-false-on-buttons
branch
from
390ba29 to
ad62d2c
Compare
This is in response to a change to button markup in the components gem which wasn't reflected in govspeak. This caused the govspeak validator to assume all buttons failed as the in-app markup was including `draggable="false"` whilst sanitised govspeak wasn't.
owenatgov
force-pushed
the
draggable-false-on-buttons
branch
from
ad62d2c to
3198495
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Adds
draggable="false"to the govspeak button extension output.Why
This is in response to a change to button markup in the components gem (alphagov/govuk_publishing_components#2448) which wasn't reflected in govspeak. This caused the govspeak validator to assume all buttons failed as the in-app markup was including
draggable="false"whilst sanitised govspeak wasn't.Zendesk ticket which prompted this
No visual changes