Reverts acronym change #229
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This code is buggy as it replaces abbreviations in HTML tag attributes, rather than just text tags. This has knock on consequences of removing HTML attachments from documents in Whitehall when creating a new edition. This commit reverts the change for now with a view to updating the logic in the near future. Zendesk: https://govuk.zendesk.com/agent/tickets/4819383
benjamineskola
approved these changes
Jan 5, 2022
1pretz1
added a commit
to alphagov/whitehall
that referenced
this pull request
Jan 5, 2022
Bump contains a fix for a publishing bug (alphagov/govspeak#229). Zendesk: https://govuk.zendesk.com/agent/tickets/4819383
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code is buggy as it replaces abbreviations in HTML tag attributes,
rather than just text tags. This has knock on consequences of removing
HTML attachments from documents in Whitehall when creating a new
edition.
This commit reverts the change for now with a view to updating the
logic in the near future.
Original commit:
https://github.com/alphagov/govspeak/pull/216/files#diff-acb6db6cd67285bd5380398c9e51ced8940ed7c4110706d038cbb243310e4055R453
Zendesk:
https://govuk.zendesk.com/agent/tickets/4819383