Fix issues with block elements inside CTA and LegislativeList #293
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkempster34
force-pushed
the
fix-images-inside-cta
branch
3 times, most recently
from
4bcc0bb to
9de8bcf
Compare
In #291, we made a change to how the call to action and legislative list components are parsed. This involved the use of the `parse_block_html` option, which enables parsing in HTML blocks until it is toggled off. Since this change, we have received Zendesk tickets regarding the use of the image component inside a call to action. Because we toggle off the parsing of HTML blocks entirely within call to actions, the HTML of the image is not parsed correctly. To fix this, we can enable parsing of the surrounding divs of the call to action and legislative list components only. This means that any inner blocks (such as the `figure` tag surrounding an image) are parsed using their default mechanism [1]. [1]: https://kramdown.gettalong.org/syntax.html#html-blocks
jkempster34
force-pushed
the
fix-images-inside-cta
branch
from
9de8bcf to
a3c7e45
Compare
mike29736
approved these changes
Oct 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/VyfTCVe1
In #291, we made a change to how the call to action and legislative list
components are parsed. This involved the use of the
parse_block_htmloption,which enables parsing in HTML blocks until it is toggled off.
Since this change, we have received Zendesk tickets regarding the use of the
image component inside a call to action. Because we toggle off the parsing of
HTML blocks entirely within call to actions, the HTML of the image is not
parsed correctly.
To fix this, we can enable parsing of the surrounding divs of the call to
action and legislative list components only. This means that any inner blocks
(such as the
figuretag surrounding an image) are parsed using their defaultmechanism 1.
Before
After
This repo is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.