Fix single line formatting of call to action component #302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkempster34
force-pushed
the
cta-same-line
branch
from
019e335 to
8f7b952
Compare
jkempster34
changed the title
jkempster34
force-pushed
the
cta-same-line
branch
4 times, most recently
from
cfa94da to
88b8967
Compare
brucebolt
approved these changes
Jan 24, 2024
We use the default mechanism for parsing the call to action component so that the parser handles abbreviations and footnotes within. Since this change (#292) we have seen a regression where defining a call to action on a single line does not work as expected (e.g., `$CTA Click here to start the program $CTA`). The closing `div` is evaluated as markdown and the call to action component therefore runs on until the next closing `div`. This can be fixed by adding in some new lines between the div tags.
jkempster34
force-pushed
the
cta-same-line
branch
from
88b8967 to
46c8fc7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://trello.com/c/iRNwQY9I
We use the default mechanism for parsing the call to action component so that
the parser handles abbreviations and footnotes within.
Since this change (#292) we have seen a regression where defining a call to
action on a single line does not work as expected (e.g.,
$CTA Click here to start the program $CTA). The closingdivis evaluated as markdown and thecall to action component therefore runs on until the next closing
div.This can be fixed by adding in some new lines between the div tags.
This repo is owned by the publishing platform team. Please let us know in #govuk-publishing-platform when you raise any PRs.