Remove Advisory component #357
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
catalinailie
force-pushed
the
remove-advisory
branch
from
65f0839 to
af41809
Compare
beccapearce
force-pushed
the
remove-advisory
branch
3 times, most recently
from
2fd2e6f to
eb11238
Compare
|
To summarise our slack conversation for ease of following, there are around 30 published editions that use the advisory component. We have a rake task we are planning to run in whitehall to remove them all. We will then check again to see if there are any instances of advisory we have missed before we merge in this PR and the related PR in govuk_publishing_components |
beccapearce
approved these changes
Jan 7, 2025
|
The whitehall rake task was sucessfully run and there are no instances of advisory that are currently published. So this PR is all good to merge. |
The advisory component has been earmarked for removal. It does not pull in styles from the design system and so has to be manually updated if it needs changing. 'Information callouts' will be used instead.
catalinailie
force-pushed
the
remove-advisory
branch
from
eb11238 to
adc5ea6
Compare
JonathanHallam
approved these changes
Jan 8, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The advisory component has been earmarked for removal. It does not pull in styles from the design system and so has to be manually updated if it needs changing.
Its uses will be replaced with information callouts.
Trello card: https://trello.com/c/Z26fvy04/2957-work-out-how-to-retire-advisory-from-govspeak-gem