Remove ContentBlock related functionality #358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Because of a degree of complexity in how Govspeak is rendered in the Publishing Platform, we can’t always fetch embedded content at the point where Govspeak is rendered (this is particuarly the case in Whitehall). With this in mind, and after some discussion with the team, we’ve decided that, for now, it’s better to handle embeds in the Publishing API. With this in mind, rather than letting this functionality die on the vine within Govspeak, we should remove the functionality altogether. As this is pretty new code (and the content modelling team are the only people aware of it and likely to use it), we should remove it from the codebase entirely.
richardTowers
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Because of a degree of complexity in how Govspeak is rendered in the Publishing Platform, we can’t always fetch embedded content at the point where Govspeak is rendered (this is particuarly the case in Whitehall). With this in mind, and after some discussion with the team, we’ve decided that, for now, it’s better to handle embeds in the Publishing API.
With this in mind, rather than letting this functionality die on the vine within Govspeak, we should remove the functionality altogether. As this is pretty new code (and the content modelling team are the only people aware of it and likely to use it), we should remove it from the codebase entirely.