Fix govspeak failures when using IALs on links #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Inline attribute lists (IALs) were added to links in Kramdown 1.6.0: gettalong/kramdown@627978525cf5ee5b290d8a1b867 5aae9cc9e2934 http://kramdown.gettalong.org/syntax.html#block-ials https://github.com/gettalong/kramdown/blob/60795eb95f1588d41e105407add2d 3ba6a7fc101/doc/news/release_1_6_0.page This changed the `add_link` signature. We monkey patch this in `kramdown_with_automatic_external_links` to add “rel=external” but we didn’t update that signature when we bumped Kramdown. There were no tests using the IAL feature so the error was not spotted. Live markdown examples do however trigger this feature, which leads to the error: `ArgumentError: wrong number of arguments (5 for 3..4)` * Include simple IAL external link test * Include kramdown’s own IAL link tests
The signature of this method has been changed upstream: https://github.com/gettalong/kramdown/blob/60795eb95f1588d41e105407add2d 3ba6a7fc101/lib/kramdown/parser/kramdown/link.rb#L38 As part of: gettalong/kramdown@627978525cf5ee5b290d8a1b867 5aae9cc9e2934 https://github.com/gettalong/kramdown/blob/60795eb95f1588d41e105407add2d 3ba6a7fc101/doc/news/release_1_6_0.page Fixes previously committed failing tests.
fofr
added a commit
that referenced
this pull request
May 9, 2016
* Fix bug with link parsing introduced in Kramdown 1.6.0 with the "inline attribute lists" feature which clashed with our monkey patch #75
Merged
fofr
added a commit
to alphagov/whitehall
that referenced
this pull request
May 9, 2016
* Increase minimum Kramdown version to 1.10.0 * Include support for right aligned columns in table * Includes fix for previously erroring IAL links: alphagov/govspeak#75
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Inline attribute lists (IALs) were added to links in Kramdown 1.6.0:
gettalong/kramdown@6279785
http://kramdown.gettalong.org/syntax.html#block-ials
https://github.com/gettalong/kramdown/blob/60795eb95f1588d41e105407add2d3ba6a7fc101/doc/news/release_1_6_0.page
This changed the
add_linksignature. We monkey patch this inkramdown_with_automatic_external_linksto add “rel=external” but we didn’t update that signature when we bumped Kramdown. There were no tests using the IAL feature so the error was not spotted. Live markdown examples do however trigger this feature, which leads to the error:add_linkmethod signatureQuestion:
I am not sure why existing markdown in content was triggering this IAL feature.