Proposal: Enable importing CSS Modules via filename convention used in common frameworks #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NickColley
force-pushed
the
proposal-004
branch
from
c1de5e9 to
d4c878d
Compare
Hanna, Ollie, Alistair, Tim and I went over your proposal together to discuss it. We’ve spent a lot of time going over this and we try to accept proposals where possible but we have decided not to accept this proposal for now for the following reasons: 1. We are not confident that we would be able to support this when issues come up. 2. We don’t currently have a way to publish ‘alpha’ / ‘experimental’ features without making breaking changes for all users. 3. We don't have time - due to constraints outside our control we need to be stricter with what we can do and can’t prioritise this work. In order to accept this in the future we’d need: 1. Evidence that CSS Modules work for all components, and how they are tested. 2. Evidence of the need from teams across Government 3. More time as a team We think that the underlying problem this tries to solve is a multi-package distribution of components. We are not not sure this has enough benefits to warrant the extra overhead required to support this, but you could consider publishing govuk-react as a single package. You can read more about our decision to publish a single package here: https://github.com/alphagov/govuk-design-system-architecture/blob/master/proposals/002-publish-one-npm-package-instead-of-multiple-npm-packages.md This said, we still believe that more investigation into CSS Modules is a worthwhile thing in the future, and hope that you continue to explore it separately within your experimental package. We’d also be open to documenting an experimental CSS Modules package within the GOV.UK Frontend installation documentation so that we can build more confidence. Co-authored-by: Hanna Laakso <[email protected]> Co-authored-by: Alasdair McLeay <[email protected]>
NickColley
force-pushed
the
proposal-004
branch
from
d4c878d to
36f14f9
Compare
|
@alphagov/design-system-developers and @penx can you take a look at this and let me know if you're happy for me to merge please? |
penx
reviewed
Feb 6, 2019
| @@ -0,0 +1,115 @@ | |||
| # Enable importing CSS Modules via filename convention used in common frameworks | |||
There was a problem hiding this comment.
Think we discussed using the word projects rather than frameworks? i.e. create-react-app vs. react
There was a problem hiding this comment.
it's a bit of a fuzzy line what is a library, framework, project.
I think it's probably OK given the subject of the proposal to use framework here.
Many people argue that React is a library not a framework 🤷♂️
There was a problem hiding this comment.
also the convention for .module.css is part of create-react-app (the build system), not React itself (the view library) but I don't mind the wording staying as-is
|
approved other than one minor comment |
penx
approved these changes
Feb 6, 2019
|
Thanks @penx |
hannalaakso
approved these changes
Feb 6, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have been working on this proposal with Alasdair and came to this conclusion:
"
Hanna, Ollie, Alistair, Tim and I went over your proposal together to discuss it.
We’ve spent a lot of time going over this and we try to accept proposals where possible but we have decided not to accept this proposal for now for the following reasons:
In order to accept this in the future we’d need:
We think that the underlying problem this tries to solve is a multi-package distribution of components. We are not not sure this has enough benefits to warrant the extra overhead required to support this, but you could consider publishing govuk-react as a single package.
You can read more about our decision to publish a single package here: https://github.com/alphagov/govuk-design-system-architecture/blob/master/proposals/002-publish-one-npm-package-instead-of-multiple-npm-packages.md
This said, we still believe that more investigation into CSS Modules is a worthwhile thing in the future, and hope that you continue to explore it separately within your experimental package.
We’d also be open to documenting an experimental CSS Modules package within the GOV.UK Frontend installation documentation so that we can build more confidence.
"