Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update research section on character count component #3537

Merged
merged 2 commits into from
Oct 21, 2024

Conversation

frankieroberto
Copy link
Contributor

@frankieroberto frankieroberto commented Feb 7, 2024

Mention the updates made in 2022, and link out to David's excellent blog post a GitHub issue comment which has more detail. Clarify that previous research (mentioned in the wiki link) was from 2017.

Copy link

netlify bot commented Feb 7, 2024

You can preview this change here:

Name Link
🔨 Latest commit 6485602
🔍 Latest deploy log https://app.netlify.com/sites/govuk-design-system-preview/deploys/671686358e796a00082e03a2
😎 Deploy Preview https://deploy-preview-3537--govuk-design-system-preview.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@stevenjmesser
Copy link
Contributor

It’ll need a review and approval from @calvin-lau-sig7 (or someone else on the team) now.

Copy link
Contributor

@owenatgov owenatgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks sharp to me.

Just needs a 2nd approval.

Mention the updates made in 2022, and link out to David's excellent blog post which has more detail.
@owenatgov owenatgov merged commit 10871be into alphagov:main Oct 21, 2024
13 checks passed
@frankieroberto frankieroberto deleted the patch-3 branch October 21, 2024 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants