Add accordion component #635
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hannalaakso
changed the title
|
You can preview this change here: Built with commit 402e483 https://deploy-preview-635--govuk-design-system-preview.netlify.com |
92 tasks
NickColley
reviewed
Nov 15, 2018
|
We can consider using the 'set capture' https://mozilla.github.io/nunjucks/templating.html#set like we do with the tabs component. |
aliuk2012
force-pushed
the
accordion-prerelease
branch
from
652a798 to
54ef088
Compare
NickColley
reviewed
Dec 17, 2018
aliuk2012
force-pushed
the
accordion-prerelease
branch
2 times, most recently
from
bd4d932 to
1c89f2a
Compare
aliuk2012
changed the title
aliuk2012
force-pushed
the
accordion-prerelease
branch
from
1c89f2a to
508eb8a
Compare
aliuk2012
force-pushed
the
accordion-prerelease
branch
from
508eb8a to
c33a651
Compare
Correction in research section to clarify it was the design not the component that was originally tested by GDS.
aliuk2012
approved these changes
Jan 10, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note for reviewers:
Please leave any comments pertaining to the guidance/documentation or the content used for the accordion on this PR.
Please leave any comments for the accordion component itself (design, code) on alphagov/govuk-frontend#958.