Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The logo in Header need to be decorative #3190

Closed
jorgeponto opened this issue Jan 19, 2023 · 0 comments · Fixed by #3272
Closed

The logo in Header need to be decorative #3190

jorgeponto opened this issue Jan 19, 2023 · 0 comments · Fixed by #3272
Assignees
Milestone

Comments

@jorgeponto
Copy link

jorgeponto commented Jan 19, 2023

In header the element actually have this code:

<!--
<!--[if IE 8]>
          <img src="/assets/images/govuk-logotype-crown.png" class="govuk-header__logotype-crown-fallback-image" width="36" height="32">
          <![endif]-->
-->

As you have in svg logo w/ aria-hidden="true" and aria-focusable="false" to declare this element as decorative to assistive technologies you need something similar to the <img element. If not we got an image without alternative text.

So change to (add alt=""):

<!--
<img src="/assets/images/govuk-logotype-crown.png" class="govuk-header__logotype-crown-fallback-image" width="36" height="32" 
                 alt="">

--> 
@36degrees 36degrees transferred this issue from alphagov/govuk-design-system-backlog Jan 20, 2023
@36degrees 36degrees self-assigned this Feb 10, 2023
@36degrees 36degrees moved this from Backlog 🗄 to In progress 📝 in GOV.UK Design System cycle board Feb 10, 2023
@36degrees 36degrees moved this from In progress 📝 to Needs review 🔍 in GOV.UK Design System cycle board Feb 10, 2023
@querkmachine querkmachine moved this from Needs review 🔍 to Ready to release 🚀 in GOV.UK Design System cycle board Feb 13, 2023
@owenatgov owenatgov added this to the [NEXT] milestone Feb 23, 2023
@querkmachine querkmachine moved this from Ready to release 🚀 to Done 🏁 in GOV.UK Design System cycle board Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

Successfully merging a pull request may close this issue.

3 participants