Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add empty alt attribute to logo IE8 fallback PNG #3272

Merged
merged 2 commits into from
Feb 10, 2023
Merged

Conversation

36degrees
Copy link
Contributor

Closes #3190.

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3272 February 10, 2023 17:04 Inactive
@36degrees
Copy link
Contributor Author

I've added an entry to the changelog.

Technically this is a markup change, but given the incredibly low number of users visiting from IE8 any more, I don’t think it’s worth instructing service teams to make this change.

At least it’ll be correct in the documentation and for anyone using our Nunjucks macros.

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3272 February 10, 2023 17:06 Inactive
Copy link
Contributor

@owenatgov owenatgov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does the job 👍🏻

@36degrees 36degrees changed the title Add empty alt tag to logo IE8 fallback PNG Add empty alt attribute to logo IE8 fallback PNG Feb 10, 2023
Technically this is a markup change, but given the incredibly low number of users visiting from IE8 any more, I don’t think it’s worth instructing service teams to make this change.

At least it’ll be correct in the documentation and for anyone using our Nunjucks macros.
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3272 February 10, 2023 17:08 Inactive
@36degrees 36degrees merged commit c9b22a1 into main Feb 10, 2023
@36degrees 36degrees deleted the header-ie8-png-alt branch February 10, 2023 17:17
@owenatgov owenatgov added this to the [NEXT] milestone Feb 17, 2023
@romaricpascal romaricpascal mentioned this pull request Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The logo in Header need to be decorative
3 participants