Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make accordion component documentation more accurate #1495

Merged
merged 2 commits into from
Jul 12, 2019
Merged

Make accordion component documentation more accurate #1495

merged 2 commits into from
Jul 12, 2019

Conversation

NickColley
Copy link
Contributor

While exploring #1494 I found that the accordion documentation needed some updates:

  • Headings are required
  • Content can be given as text, not only html

@NickColley NickColley changed the title Update documentation for accordions Make accordion component documentation more accurate Jul 12, 2019
36degrees
36degrees approved these changes Jul 12, 2019
View reviewed changes
Copy link
Contributor

@36degrees 36degrees left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Top doccage 👏

@NickColley NickColley merged commit 9798466 into master Jul 12, 2019
@NickColley NickColley deleted the update-documentation-for-accordions branch July 12, 2019 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@36degrees 36degrees 36degrees approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@NickColley @36degrees @govuk-design-system-ci