Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DO NOT MERGE] Internationalisation support #2614

Closed
wants to merge 34 commits into from
Closed
Changes from 1 commit
Commits
Show all changes
34 commits
Select commit Hold shift + click to select a range
9eddfab
Allow localisation of copyright and content licence
querkmachine May 27, 2022
1a29a44
Add parameters to hide the OGL and Crown Copyright graphics
querkmachine May 30, 2022
33d788b
Add parameter to localise mobile menu toggle button
querkmachine May 30, 2022
cc88f85
Enable custom limit hint text on character count
querkmachine May 30, 2022
1cb8938
i18n support prototype
querkmachine Apr 28, 2022
45aaa93
Add pluralisation support for fallback phrases
querkmachine May 11, 2022
e62bf24
Export I18n function
querkmachine May 11, 2022
9f1b448
Fix some last-minute refactoring removing something it shouldn't
querkmachine May 11, 2022
139e0fd
Tidy up documentation
querkmachine May 11, 2022
db3f03e
Changes for IE9–11 support
querkmachine May 23, 2022
eed52b5
Polyfill Object.keys for IE8
querkmachine May 23, 2022
4c174a2
Polyfill Array.prototype.indexOf for IE8
querkmachine May 23, 2022
044ac8b
Don't run flatten method if no translations are passed in
querkmachine May 24, 2022
cbbd1d8
Rename i18n function to I18n
querkmachine May 25, 2022
044a311
Refactor I18n to use a singleton pattern
querkmachine May 25, 2022
c84e74a
Document getInstance function
querkmachine May 25, 2022
f8a4c9f
Add error checking for an invalid lookup key
querkmachine May 26, 2022
b50767f
Validate that count option is a number we can use
querkmachine May 26, 2022
e9bb7e0
Remove separator configuration option
querkmachine May 26, 2022
6e49322
Add check for if a string contains placeholders
querkmachine May 26, 2022
49f5605
Remove debug code
querkmachine May 26, 2022
c869791
Amend tests for I18n support
querkmachine May 31, 2022
a56fd78
Make I18n a private function
querkmachine Jun 6, 2022
d2dee7c
Remove demo configuration
querkmachine Jun 7, 2022
bae8012
Add localised components full-page example
querkmachine Jun 8, 2022
3127cf3
Add localisation tests
querkmachine Jun 8, 2022
220a5d7
Update character count fallback text test
querkmachine Jun 8, 2022
7478719
Add code to progressively enhance to Intl.PluralRules
querkmachine Jun 9, 2022
64977b3
Remove duplicated localisation example
querkmachine Jun 13, 2022
1bfc346
Add localised number formatting for 'count'
querkmachine Jun 13, 2022
9e2f3f1
Spike component-level approach to i18n initialisation
querkmachine Jun 20, 2022
39d2e7c
Fix tests
querkmachine Jun 20, 2022
ba97460
Swap out Object.assign polyfill
querkmachine Jun 21, 2022
0697445
Rename new .js files to .mjs
querkmachine Jun 23, 2022
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove duplicated localisation example
querkmachine committed Jun 23, 2022
commit 64977b3330bec39c8c6a5f41e48eeabfa545395b
10 changes: 0 additions & 10 deletions src/govuk/components/character-count/character-count.yaml
Original file line number Diff line number Diff line change
@@ -96,16 +96,6 @@ examples:
hint:
text: Don't include personal or financial information, eg your
National Insurance number or credit card details.

- name: with customised limit hint
description: Fallback limit text translated to Welsh
data:
name: with-limit-hint
id: with-limit-hint
maxlength: 10
label:
text: Can you provide more detail?
limitHint: Gallwch nodi hyd at %{count} nod

- name: with default value
data: