Remove unused classList polyfill from header component JavaScript
#3112
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-3112
36degrees
changed the title
classList polyfill from headerclassList polyfill from header component JavaScript
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-pr-3112
36degrees
added a commit
that referenced
this pull request
Dec 20, 2022
We shipped 4.4.1 from the support/4.4.x branch without the other changes from main. It looks like when #3112 was merged Git cleanly merged the changelog entry but it incorrectly ended up listed as part of v4.4.1. Move the entry for this PR to the 'Unreleased' section.
36degrees
added a commit
that referenced
this pull request
Dec 20, 2022
We shipped 4.4.1 from the support/4.4.x branch without the other changes from main. It looks like when #3112 was merged Git cleanly merged the changelog entry but it incorrectly ended up listed as part of v4.4.1. Move the entry for this PR to the 'Unreleased' section.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The header imports the
Element.prototype.classListpolyfill but hasn’t actually calledclassListanywhere since we updated it to use thehiddenattribute to toggle the menu visibility in 7217a7f (#2727).