-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate govuk-button--disabled
class
#3326
Conversation
19f507b
to
f26f0df
Compare
f26f0df
to
fb1a59d
Compare
fb1a59d
to
01e71b6
Compare
01e71b6
to
f55d804
Compare
f55d804
to
266e2dd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me @querkmachine 🙌
Assuming that the Deprecating a CSS class docs are definitely correct
@36degrees I can see the docs landed recently in #2679, can we check if the CSS class example was supposed to be double-slashed?
// @deprecated
.govuk-foo-old-class-name {
foo: bar;
}
Yeah, I think so – this isn't SassDoc as SassDoc isn't designed to be used to document CSS. Appreciate it's confusing – open to suggestions if there's a better way of doing it. |
@36degrees Brill, no just checking Sass syntax highlighting kicks in at triple-slash so it seemed like the sensible answer. We don't have new lines below comments in those docs (but do across our Sass files) so perhaps that's the only inconsistency? |
Notes the deprecation of the
govuk-button--disabled
class in Sass and the changelog.Closes #2271.