Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate govuk-button--disabled class #3326

Merged
merged 1 commit into from
Feb 23, 2023

Conversation

querkmachine
Copy link
Member

Notes the deprecation of the govuk-button--disabled class in Sass and the changelog.

Closes #2271.

@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3326 February 22, 2023 16:46 Inactive
@querkmachine querkmachine force-pushed the deprecate-button-disabled-class branch from 19f507b to f26f0df Compare February 22, 2023 16:53
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3326 February 22, 2023 16:53 Inactive
@querkmachine querkmachine self-assigned this Feb 22, 2023
@querkmachine querkmachine requested a review from a team February 22, 2023 16:54
@querkmachine querkmachine marked this pull request as ready for review February 22, 2023 16:54
@querkmachine querkmachine force-pushed the deprecate-button-disabled-class branch from f26f0df to fb1a59d Compare February 22, 2023 16:57
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3326 February 22, 2023 16:57 Inactive
@querkmachine querkmachine force-pushed the deprecate-button-disabled-class branch from fb1a59d to 01e71b6 Compare February 22, 2023 16:57
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3326 February 22, 2023 16:58 Inactive
CHANGELOG.md Outdated Show resolved Hide resolved
@querkmachine querkmachine force-pushed the deprecate-button-disabled-class branch from 01e71b6 to f55d804 Compare February 23, 2023 13:12
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3326 February 23, 2023 13:12 Inactive
@querkmachine querkmachine force-pushed the deprecate-button-disabled-class branch from f55d804 to 266e2dd Compare February 23, 2023 13:29
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-3326 February 23, 2023 13:29 Inactive
@colinrotherham colinrotherham self-requested a review February 23, 2023 14:22
Copy link
Contributor

@colinrotherham colinrotherham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me @querkmachine 🙌

Assuming that the Deprecating a CSS class docs are definitely correct

@36degrees I can see the docs landed recently in #2679, can we check if the CSS class example was supposed to be double-slashed?

// @deprecated
.govuk-foo-old-class-name {
  foo: bar;
}

@36degrees
Copy link
Contributor

Yeah, I think so – this isn't SassDoc as SassDoc isn't designed to be used to document CSS.

Appreciate it's confusing – open to suggestions if there's a better way of doing it.

@colinrotherham
Copy link
Contributor

Yeah, I think so – this isn't SassDoc as SassDoc isn't designed to be used to document CSS.

Appreciate it's confusing – open to suggestions if there's a better way of doing it.

@36degrees Brill, no just checking

Sass syntax highlighting kicks in at triple-slash so it seemed like the sensible answer. We don't have new lines below comments in those docs (but do across our Sass files) so perhaps that's the only inconsistency?

@querkmachine querkmachine merged commit 27203d2 into main Feb 23, 2023
@querkmachine querkmachine deleted the deprecate-button-disabled-class branch February 23, 2023 15:36
@romaricpascal romaricpascal mentioned this pull request Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate govuk-button--disabled - ability to style link buttons as disabled
4 participants