Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable editorconfig linting temporarily #5586

Merged
merged 1 commit into from
Jan 9, 2025
Merged

Conversation

domoscargin
Copy link
Contributor

The lint:editorconfig task is failing

This is likely due to some editorconfig-checker bug - the base package has had some issues with missing binaries

Disabling this check to enable releasing v5.8.0.

We can wait on Dependabot to propagate any fix our way.

The lint:editorconfig task is failing (https://github.com/alphagov/govuk-frontend/actions/runs/12687255381/job/35361300690)

This is likely due to some editorconfig-checker bug - the base package has had some issues with missing binaries: https://github.com/editorconfig-checker/editorconfig-checker/releases/tag/v3.1.1

Disabling this check to enable releasing v5.8.0.
@domoscargin domoscargin requested a review from a team as a code owner January 9, 2025 10:20
@domoscargin domoscargin added the github_actions Pull requests that update GitHub Actions code label Jan 9, 2025
@govuk-design-system-ci govuk-design-system-ci temporarily deployed to govuk-frontend-pr-5586 January 9, 2025 10:20 Inactive
Copy link

github-actions bot commented Jan 9, 2025

📋 Stats

File sizes

File Size
dist/govuk-frontend-development.min.css 118.41 KiB
dist/govuk-frontend-development.min.js 42.7 KiB
packages/govuk-frontend/dist/govuk/all.bundle.js 92.81 KiB
packages/govuk-frontend/dist/govuk/all.bundle.mjs 87.12 KiB
packages/govuk-frontend/dist/govuk/all.mjs 1.25 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend-component.mjs 1.74 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.css 118.4 KiB
packages/govuk-frontend/dist/govuk/govuk-frontend.min.js 42.69 KiB
packages/govuk-frontend/dist/govuk/i18n.mjs 5.55 KiB
packages/govuk-frontend/dist/govuk/init.mjs 7.13 KiB

Modules

File Size (bundled) Size (minified)
all.mjs 82.57 KiB 40.4 KiB
accordion.mjs 26.58 KiB 13.41 KiB
button.mjs 9.09 KiB 3.78 KiB
character-count.mjs 25.39 KiB 10.9 KiB
checkboxes.mjs 7.81 KiB 3.42 KiB
error-summary.mjs 10.99 KiB 4.54 KiB
exit-this-page.mjs 20.2 KiB 10.34 KiB
header.mjs 6.46 KiB 3.22 KiB
notification-banner.mjs 9.35 KiB 3.7 KiB
password-input.mjs 18.24 KiB 8.33 KiB
radios.mjs 6.81 KiB 2.98 KiB
service-navigation.mjs 6.44 KiB 3.26 KiB
skip-link.mjs 6.4 KiB 2.76 KiB
tabs.mjs 12.04 KiB 6.67 KiB

View stats and visualisations on the review app


Action run for cc1766d

@domoscargin domoscargin merged commit db96257 into main Jan 9, 2025
49 checks passed
@domoscargin domoscargin deleted the bk-editorconfig-bug branch January 9, 2025 10:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
Status: Done 🏁
Development

Successfully merging this pull request may close these issues.

3 participants