Namespace exports with 'govuk' #732
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-732
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-732
|
Thought – do we want to standardise on how we construct these strings to avoid conflicts across layers? e.g. |
|
@36degrees can do, i see no issue with it. will amend |
govuk-design-system-ci
temporarily deployed
to
govuk-frontend-review-pr-732
|
@36degrees updated the exports with layer names |
NickColley
reviewed
May 30, 2018
| @@ -2,7 +2,7 @@ | |||
| @import "../../tools/all"; | |||
| @import "../../helpers/all"; | |||
|
|
|||
| @include govuk-exports("back-link") { | |||
| @include govuk-exports("govuk/component/back-link") { | |||
There was a problem hiding this comment.
'component' -> 'components'
There was a problem hiding this comment.
I'd argue for the use of singular
There was a problem hiding this comment.
It's a bit weird having component, but helpers, objects, utilities. But probably not going back and changing now.
There was a problem hiding this comment.
It's not part of the public api, so not too much trouble
kr8n3r
changed the title
kr8n3r
changed the title
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have found that an application using the same export as us, it will conflict resulting in a broken build.
For example, when releasing the Header component, it conflicted with the application level export.
This fixes: #724
Trello ticket: https://trello.com/c/UaX5dWyO/1025-namespace-all-scss-exports-with-govuk