-
Notifications
You must be signed in to change notification settings - Fork 339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Accordion component #958
Merged
aliuk2012
merged 50 commits into
alphagov:master
from
frankieroberto:add-accordion-component
Jan 10, 2019
+930
−3
Merged
Accordion component #958
Changes from 1 commit
Commits
Show all changes
50 commits
Select commit
Hold shift + click to select a range
a0e3a5c
Initial port of Accordion component
frankieroberto a29c419
Refactor to follow JS Standard and GOV.UK Frontend conventions
frankieroberto ce3507f
Refactor to follow govuk CSS naming convention
frankieroberto 2bdfcd8
Add tests
frankieroberto 493b873
Add $sections in Accordion module
hannalaakso 961b4b4
Set button attributes in separate function
hannalaakso c2cf60f
Update the macro to allow setting initial state
frankieroberto 80f4703
Add examples and params
hannalaakso 56842f9
Add aria-labelledby relationship
frankieroberto 78ccb57
Accessibility improvements
frankieroberto 6de7352
Rename 'body' to 'panel'
frankieroberto 3bc5f98
Switch to `index` over `index0`
frankieroberto e421382
Remove region role from panel
frankieroberto 994b7b3
Replace button div with button element
frankieroberto 7eafd31
Ability to specify html in header
frankieroberto 2fbe98f
Adds the state of the accordion panel to sessionStorage so the accord…
injms 41409dc
Add test to check if expanded state is stored
hannalaakso 9d632a7
Add focus style
frankieroberto a1fc105
Add support for headingLevel param
frankieroberto 95bc46a
Replace background image with inline SVG
frankieroberto fcd909c
Remove custom enter/space key handling
frankieroberto 6550027
Check if console is available before logging
frankieroberto 0f995a7
Margin and padding adjustments
frankieroberto 7b71ccb
Add visually hidden text to "Open/Close all" button
hannalaakso a823816
Fix bug of <h2> and <div> inside <h2>
hannalaakso f58cd8b
Make BEM naming consistent with GOV.UK Frontend
hannalaakso 7be772a
Standardise public API
hannalaakso 0fe008c
Expand focus state to fill the heading
hannalaakso 5fa40af
Add template tests
hannalaakso 89f0b6c
Standardise "with JS" classes
hannalaakso ee411e6
Fix background button colour on FF adjusted colours view
hannalaakso 6fd81b2
Replaces SVG +/- icon with CSS version.
hannalaakso 245a56c
Fixes "Deep spot" in the header
aliuk2012 48db868
Add borders to show on no-JS view. Some refactoring.
hannalaakso 3f551f5
Rename "expand-all" to "open-all"
hannalaakso 661b230
Rename all instance of "panel" to "content"
hannalaakso 8552fd2
Fix summary overlapping icon on mobile
hannalaakso 6e0d834
Prefix section classes with "section"
hannalaakso cf5ffd9
Fix icon not changing colour in FF inverted colours view
hannalaakso 2d29ff0
Update component README
hannalaakso 395380d
Update CHANGELOG
hannalaakso 027373d
Tidy up of `accordion.js`
hannalaakso a8d77a0
Simplify expanding logic
hannalaakso 81e6b0d
Some general restructuring
hannalaakso c85f879
Move `govuk-heading-m` styles to scss, remove from template
hannalaakso cea28fe
Future proof `<span>` to `<button>` code
hannalaakso 04b0ce6
Remove IE8 trigger reflow hack
hannalaakso c3957c6
fixes IE8 issue with "+/-" icons not being toggled
aliuk2012 67ae320
Refactors Accordion.js
aliuk2012 3845701
Store class names in `accordion.js` in `$module`
hannalaakso File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix icon not changing colour in FF inverted colours view
Thanks @36degrees Plus some minor SCSS fixes
- Loading branch information
commit cf5ffd9b7590e4021d7d16d587cb03107a938c8c
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
could this be
currentColor
? That'll mean that when users change their colours it will override as expected.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @NickColley.
currentColor
is not supported by IE8. I've just added in a fix which makes sure that the icon displays for users who change their colours.