Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Accordion component #958

Merged
merged 50 commits into from
Jan 10, 2019
Merged
Changes from 1 commit
Commits
Show all changes
50 commits
Select commit Hold shift + click to select a range
a0e3a5c
Initial port of Accordion component
frankieroberto Jan 4, 2019
a29c419
Refactor to follow JS Standard and GOV.UK Frontend conventions
frankieroberto Jan 4, 2019
ce3507f
Refactor to follow govuk CSS naming convention
frankieroberto Aug 20, 2018
2bdfcd8
Add tests
frankieroberto Aug 20, 2018
493b873
Add $sections in Accordion module
hannalaakso Aug 30, 2018
961b4b4
Set button attributes in separate function
hannalaakso Aug 30, 2018
c2cf60f
Update the macro to allow setting initial state
frankieroberto Oct 11, 2018
80f4703
Add examples and params
hannalaakso Jan 4, 2019
56842f9
Add aria-labelledby relationship
frankieroberto Oct 25, 2018
78ccb57
Accessibility improvements
frankieroberto Oct 25, 2018
6de7352
Rename 'body' to 'panel'
frankieroberto Oct 25, 2018
3bc5f98
Switch to `index` over `index0`
frankieroberto Oct 30, 2018
e421382
Remove region role from panel
frankieroberto Oct 30, 2018
994b7b3
Replace button div with button element
frankieroberto Oct 30, 2018
7eafd31
Ability to specify html in header
frankieroberto Nov 1, 2018
2fbe98f
Adds the state of the accordion panel to sessionStorage so the accord…
injms Nov 6, 2018
41409dc
Add test to check if expanded state is stored
hannalaakso Jan 4, 2019
9d632a7
Add focus style
frankieroberto Nov 6, 2018
a1fc105
Add support for headingLevel param
frankieroberto Nov 6, 2018
95bc46a
Replace background image with inline SVG
frankieroberto Nov 7, 2018
fcd909c
Remove custom enter/space key handling
frankieroberto Nov 8, 2018
6550027
Check if console is available before logging
frankieroberto Nov 15, 2018
0f995a7
Margin and padding adjustments
frankieroberto Nov 16, 2018
7b71ccb
Add visually hidden text to "Open/Close all" button
hannalaakso Dec 11, 2018
a823816
Fix bug of <h2> and <div> inside <h2>
hannalaakso Dec 12, 2018
f58cd8b
Make BEM naming consistent with GOV.UK Frontend
hannalaakso Dec 12, 2018
7be772a
Standardise public API
hannalaakso Dec 12, 2018
0fe008c
Expand focus state to fill the heading
hannalaakso Jan 9, 2019
5fa40af
Add template tests
hannalaakso Dec 17, 2018
89f0b6c
Standardise "with JS" classes
hannalaakso Dec 17, 2018
ee411e6
Fix background button colour on FF adjusted colours view
hannalaakso Dec 17, 2018
6fd81b2
Replaces SVG +/- icon with CSS version.
hannalaakso Jan 9, 2019
245a56c
Fixes "Deep spot" in the header
aliuk2012 Dec 17, 2018
48db868
Add borders to show on no-JS view. Some refactoring.
hannalaakso Dec 17, 2018
3f551f5
Rename "expand-all" to "open-all"
hannalaakso Dec 17, 2018
661b230
Rename all instance of "panel" to "content"
hannalaakso Dec 18, 2018
8552fd2
Fix summary overlapping icon on mobile
hannalaakso Dec 18, 2018
6e0d834
Prefix section classes with "section"
hannalaakso Jan 9, 2019
cf5ffd9
Fix icon not changing colour in FF inverted colours view
hannalaakso Dec 18, 2018
2d29ff0
Update component README
hannalaakso Dec 18, 2018
395380d
Update CHANGELOG
hannalaakso Dec 18, 2018
027373d
Tidy up of `accordion.js`
hannalaakso Dec 19, 2018
a8d77a0
Simplify expanding logic
hannalaakso Jan 3, 2019
81e6b0d
Some general restructuring
hannalaakso Jan 4, 2019
c85f879
Move `govuk-heading-m` styles to scss, remove from template
hannalaakso Jan 4, 2019
cea28fe
Future proof `<span>` to `<button>` code
hannalaakso Jan 3, 2019
04b0ce6
Remove IE8 trigger reflow hack
hannalaakso Jan 3, 2019
c3957c6
fixes IE8 issue with "+/-" icons not being toggled
aliuk2012 Jan 4, 2019
67ae320
Refactors Accordion.js
aliuk2012 Dec 24, 2018
3845701
Store class names in `accordion.js` in `$module`
hannalaakso Jan 4, 2019
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix icon not changing colour in FF inverted colours view
Thanks @36degrees

Plus some minor SCSS fixes
  • Loading branch information
hannalaakso authored and aliuk2012 committed Jan 9, 2019
commit cf5ffd9b7590e4021d7d16d587cb03107a938c8c
2 changes: 2 additions & 0 deletions src/components/accordion/_accordion.scss
Original file line number Diff line number Diff line change
@@ -148,6 +148,7 @@
.govuk-accordion__icon:after,
.govuk-accordion__icon:before {
content: "";
box-sizing: border-box;
position: absolute;
top: 0;
right: 0;
@@ -156,6 +157,7 @@
width: 25%;
height: 25%;
margin: auto;
border: 2px solid transparent;
background-color: govuk-colour("black");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could this be currentColor? That'll mean that when users change their colours it will override as expected.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @NickColley. currentColor is not supported by IE8. I've just added in a fix which makes sure that the icon displays for users who change their colours.

}