-
Notifications
You must be signed in to change notification settings - Fork 236
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing detail to Updating the Kit Documentation #286
Closed
paulmsmith
wants to merge
1
commit into
alphagov:master
from
paulmsmith:feature/updating-via-git-additional-step
Closed
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think it would be good if this is consistent with the instructions already in the docs:
install/install-the-kit.md
install/run-the-kit.md
In terminal:
npm start
After the kit has started, you should see a message telling you that the kit is running:
Listening on port 3000 url: http://localhost:3000
If you see an error after updating, you may need to download extra code used by the kit before it can run.
You can get this by running:
npm install
The install may take up to a minute. Whilst installing it may WARN about some items - this is ok. As long as there are no ERRORs you can continue.
In terminal:
npm start
After the kit has started, you should see a message telling you that the kit is running:
Listening on port 3000 url: http://localhost:3000
If you still have an error, you can raise an issue within github or ask in the Slack channel for users of the prototype kit.
Try to provide as much information as you can about the error and the computer you are attempting to run the prototyping kit on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc. @edwardhorsford as I'm copy-and-pasting your docs here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Better to repeat that in context with the upgrade docs or link to it from the documentation I've written?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think its easy to link to this content as it stands, so yeh just copying and pasting for consistency would be good.
I don't think we need the second instance of:
as we've just said that above